From: khilman@kernel•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] PCI: iproc: fix 32-bit build error
Date: Tue, 13 Oct 2015 14:21:35 -0700 [thread overview]
Message-ID: <7hwpuqcvmo.fsf@deeprootsystems.com> (raw)
In-Reply-To: <11199595.GgDE2yo8AA@wuerfel> (Arnd Bergmann's message of "Tue, 13 Oct 2015 22:02:48 +0200")
Arnd Bergmann <arnd@arndb•de> writes:
> The iproc PCI driver tries to figure out whether the MMIO window has
> a valid size, but does this using a 64-bit modulo operation, which
> is not allowed on 32-bit kernels and leads to a link error:
>
> drivers/built-in.o: In function `iproc_pcie_setup':
> :(.text+0x4b798): undefined reference to `__aeabi_uldivmod'
>
> This works around that error by using the div64_u64() function
> provided by the kernel. While this is an expensive operation,
> it is harmless because we only call it during the probing
> of the driver.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> Fixes: 0ab99ca8eb6c ("PCI: iproc: Fix compile warnings")
Tested-by: Kevin Hilman <khilman@linaro•org>
Verified that this fixes the build failure on arm multi_v7_defconfig +
CONFIG_ARM_LPAE=y on top of next-20151013.
Kevin
next prev parent reply other threads:[~2015-10-13 21:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 0:39 [PATCH 0/8] Broadcom iProc PCIe fixes and outbound mapping support Ray Jui
2015-09-16 0:39 ` [PATCH 1/8] PCI: iproc: Fix code comment Ray Jui
2015-09-16 0:39 ` [PATCH 2/8] PCI: iproc: Remove unused code Ray Jui
2015-09-16 0:39 ` [PATCH 3/8] PCI: iproc: Remove ARCH specific flag Ray Jui
2015-09-16 0:39 ` [PATCH 4/8] PCI: iproc: Fix PCIe reset logic Ray Jui
2015-09-16 0:39 ` [PATCH 5/8] PCI: iproc: Improve link detection logic Ray Jui
2015-09-16 0:39 ` [PATCH 6/8] PCI: iproc: Update iProc PCIe device tree bindings Ray Jui
2015-09-16 0:39 ` [PATCH 7/8] PCI: iproc: Add outbound mapping support Ray Jui
2015-10-13 17:58 ` Kevin Hilman
2015-10-13 20:02 ` [PATCH] PCI: iproc: fix 32-bit build error Arnd Bergmann
2015-10-13 20:06 ` Hauke Mehrtens
2015-10-13 20:11 ` Ray Jui
2015-10-13 21:00 ` Arnd Bergmann
2015-10-15 16:00 ` Bjorn Helgaas
2015-10-15 16:19 ` Ray Jui
2015-10-15 19:40 ` [PATCH v2] " Arnd Bergmann
2015-10-15 20:57 ` Hauke Mehrtens
2015-10-15 21:01 ` Bjorn Helgaas
2015-10-16 9:47 ` Arnd Bergmann
2015-10-16 13:23 ` Bjorn Helgaas
2015-10-13 21:21 ` Kevin Hilman [this message]
2015-09-16 0:39 ` [PATCH 8/8] PCI: iproc: Fix compile warnings Ray Jui
2015-09-25 23:21 ` [PATCH 0/8] Broadcom iProc PCIe fixes and outbound mapping support Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hwpuqcvmo.fsf@deeprootsystems.com \
--to=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox