From: khilman@linaro•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v8 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC
Date: Fri, 25 Apr 2014 15:52:54 -0700 [thread overview]
Message-ID: <7hwqedf2d5.fsf@paris.lan> (raw)
In-Reply-To: <1397459860-21869-2-git-send-email-t.dakhran@samsung.com> (Tarek Dakhran's message of "Mon, 14 Apr 2014 11:17:38 +0400")
Tarek Dakhran <t.dakhran@samsung•com> writes:
> EXYNOS5410 is SoC in Samsung's Exynos5 SoC series.
> Add initial support for this SoC.
>
> Signed-off-by: Tarek Dakhran <t.dakhran@samsung•com>
> Signed-off-by: Vyacheslav Tyrtov <v.tyrtov@samsung•com>
> Reviewed-by: Tomasz Figa <t.figa@samsung•com>
[...]
> diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c
> index 5eead53..83ae5fb 100644
> --- a/arch/arm/mach-exynos/hotplug.c
> +++ b/arch/arm/mach-exynos/hotplug.c
> @@ -95,8 +95,8 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
> for (;;) {
>
> /* make cpu1 to be turned off at next WFI command */
> - if (cpu == 1)
> - __raw_writel(0, S5P_ARM_CORE1_CONFIGURATION);
> + if (cpu > 0)
> + __raw_writel(0, S5P_ARM_CORE_CONFIGURATION(cpu));
This looks like a fix that's probably not specific to the 5410 and maybe
deserves it's own patch?
[...]
> @@ -107,14 +111,14 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle)
> */
> write_pen_release(phys_cpu);
>
> - if (!(__raw_readl(S5P_ARM_CORE1_STATUS) & S5P_CORE_LOCAL_PWR_EN)) {
> + if (!(__raw_readl(S5P_ARM_CORE_STATUS(cpu)) & S5P_CORE_LOCAL_PWR_EN)) {
> __raw_writel(S5P_CORE_LOCAL_PWR_EN,
> - S5P_ARM_CORE1_CONFIGURATION);
> + S5P_ARM_CORE_CONFIGURATION(cpu));
>
> timeout = 10;
>
> /* wait max 10 ms until cpu1 is on */
> - while ((__raw_readl(S5P_ARM_CORE1_STATUS)
> + while ((__raw_readl(S5P_ARM_CORE_STATUS(cpu))
> & S5P_CORE_LOCAL_PWR_EN) != S5P_CORE_LOCAL_PWR_EN) {
> if (timeout-- == 0)
> break;
...and this hunk too?
Kevin
next prev parent reply other threads:[~2014-04-25 22:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 7:17 [PATCH v8 0/3] Exynos 5410 support Tarek Dakhran
2014-04-14 7:17 ` [PATCH v8 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC Tarek Dakhran
2014-04-14 11:03 ` Arnd Bergmann
2014-04-14 11:59 ` Tarek Dakhran
2014-04-24 16:01 ` Tomasz Figa
2014-04-25 22:52 ` Kevin Hilman [this message]
2014-04-25 23:07 ` Tomasz Figa
2014-04-14 7:17 ` [PATCH v8 2/3] clk: exynos5410: register clocks using common clock framework Tarek Dakhran
2014-04-14 7:17 ` [PATCH v8 3/3] ARM: dts: Add initial device tree support for EXYNOS5410 Tarek Dakhran
2014-04-26 11:41 ` Tomasz Figa
2014-04-26 15:31 ` Tarek Dakhran
2014-04-25 22:56 ` [PATCH v8 0/3] Exynos 5410 support Kevin Hilman
2014-05-19 0:58 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hwqedf2d5.fsf@paris.lan \
--to=khilman@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox