From: khilman@kernel•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [RESEND/PATCH] i2c: pxa: Use suspend() and resume() instead of the _noirq hooks
Date: Wed, 22 Oct 2014 17:25:02 -0700 [thread overview]
Message-ID: <7hzjcnaazl.fsf@deeprootsystems.com> (raw)
In-Reply-To: <54482EB1.9030407@vanguardiasur.com.ar> (Ezequiel Garcia's message of "Wed, 22 Oct 2014 19:24:49 -0300")
Ezequiel Garcia <ezequiel@vanguardiasur•com.ar> writes:
> On 10/20/2014 06:07 PM, Kevin Hilman wrote:
>> Ezequiel Garcia <ezequiel@vanguardiasur•com.ar> writes:
>>
>>> The _noirq were previously chosen to make sure all the users of the
>>> adapter were suspended by the time the adapter itself enters the
>>> suspended state.
>>>
>>> The {suspend,resume}_noirq usage was converted from an earlier
>>> implementation based on suspend_late and resume_early on this commit:
>>>
>>> commit 57f4d4f1b72983f8c76e2f232e064730aeffe599
>>> Author: Magnus Damm <damm@igel•co.jp>
>>> Date: Wed Jul 8 13:22:39 2009 +0200
>>>
>>> I2C: Rework i2c-pxa suspend_late()/resume_early()
>>>
>>> However, all the I2C devices are probed as children of its I2C adapter,
>>> and hence the device model guarantees they are suspended before its parent, and
>>> resumed after it.
>>>
>>> In other words, there's no need to use the _noirq hooks to get a suspend/resume
>>> device/adapter order.
>>
>> Are you sure *really* about this?
>>
>
> Hm, now you made me doubt.
Good. :)
>> It's usally not the children that are the problem here. It's usually
>> some other driver trying to use an I2C device e.g. MMC changing voltage
>> using an I2C-based PMIC during its suspend process.
>>
>
> So we can't know for sure if using suspend/resume is going to work OK for
> a I2C adapter?
>
> There might be some use of it that can't be accurately modeled in the
> device model.
Correct.
> I.e., the above example is a dependency of MMC on the I2C being suspended
> after him, but right now there's no way to model such relationship.
That's right. That's why many i2c drivers are using the late/early
callbacks for suspend/resume.
suspend/resume order depends on probe ordering, so with deferred probe,
the probe ordering might be right, but it should be thoroughly tested.
Kevin
next prev parent reply other threads:[~2014-10-23 0:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 18:23 [RESEND/PATCH] i2c: pxa: Use suspend() and resume() instead of the _noirq hooks Ezequiel Garcia
2014-10-20 21:07 ` Kevin Hilman
2014-10-22 22:24 ` Ezequiel Garcia
2014-10-23 0:25 ` Kevin Hilman [this message]
2014-11-13 0:21 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hzjcnaazl.fsf@deeprootsystems.com \
--to=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox