From: Shivendra Pratap <shivendra.pratap@oss•qualcomm.com>
To: Lee Jones <lee@kernel•org>, Bartosz Golaszewski <brgl@kernel•org>
Cc: Sebastian Reichel <sre@kernel•org>,
Mark Rutland <mark.rutland@arm•com>,
Lorenzo Pieralisi <lpieralisi@kernel•org>,
"Rafael J. Wysocki" <rafael@kernel•org>,
Daniel Lezcano <daniel.lezcano@kernel•org>,
Christian Loehle <christian.loehle@arm•com>,
Ulf Hansson <ulfh@kernel•org>, Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Arnd Bergmann <arnd@arndb•de>,
Souvik Chakravarty <Souvik.Chakravarty@arm•com>,
Andy Yan <andy.yan@rock-chips•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
John Stultz <john.stultz@linaro•org>,
Moritz Fischer <moritz.fischer@ettus•com>,
Sudeep Holla <sudeep.holla@kernel•org>,
linux-pm@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-arm-msm@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, devicetree@vger•kernel.org,
Florian Fainelli <florian.fainelli@broadcom•com>,
Krzysztof Kozlowski <krzk@kernel•org>,
Dmitry Baryshkov <dmitry.baryshkov@oss•qualcomm.com>,
Mukesh Ojha <mukesh.ojha@oss•qualcomm.com>,
Andre Draszik <andre.draszik@linaro•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Kathiravan Thirumoorthy
<kathiravan.thirumoorthy@oss•qualcomm.com>,
Srinivas Kandagatla <srini@kernel•org>,
Bartosz Golaszewski <bartosz.golaszewski@oss•qualcomm.com>
Subject: Re: [PATCH v22 08/13] mfd: core: Add firmware-node support to MFD cells
Date: Thu, 4 Jun 2026 00:21:32 +0530 [thread overview]
Message-ID: <81680397-3bbd-4f66-9166-546c8fe753fc@oss.qualcomm.com> (raw)
In-Reply-To: <c034a7c5-7215-4e96-80cf-ef0c51f8291b@oss.qualcomm.com>
On 25-05-2026 15:04, Shivendra Pratap wrote:
>
>
> On 22-05-2026 14:38, Bartosz Golaszewski wrote:
>> On Thu, May 21, 2026 at 6:27 PM Lee Jones <lee@kernel•org> wrote:
>>>
>>> On Thu, 21 May 2026, Bartosz Golaszewski wrote:
>>>
>>>> On Thu, May 21, 2026 at 3:24 PM Lee Jones <lee@kernel•org> wrote:
>>>>>
>>>>>>
>>>>>> I suggested it because of its flexibility. The alternative I had in
>>>>>> mind is something like a new field in mfd_cell:
>>>>>>
>>>>>> const char *cell_node_name;
>>>>>>
>>>>>> Which - if set - would tell MFD to look up an fwnode that's a
>>>>>> child of
>>>>>> the parent device's node by name - as it may not have a compatible.
>>>>>
>>>>> Remind me why the chlid device can't look-up its own fwnode?
>>>>>
>>>>
>>>> Oh sure it can, but should it? I'm not sure it's logically sound to
>>>> have the child device reach into the parent, look up the fwnode and
>>>> then assign it to itself after it's already attached to the driver.
>>>> This should be done at the subsystem level before the device is
>>>> registered.
>>>
>>> Leaf drivers reach back into the parent all the time.
>>>
>>
>> But drivers don't generally assign firmware nodes to devices they are
>> already bound to. This is racy as in probe() the device is already
>> visible to the system. There's no synchronization of device property
>> access - properties are assumed to be read-only for a registered
>> device.
>
> thanks Bart/Lee. Any pointers to take this from here?
Hi Lee,
To take this patchset forward, it would be helpful to get your views on
fwnode based addition in mfd-core. Maybe, a member like "*named_fwnode"
in mfd-core and then a lookup logic, or any alternatives?
thanks,
Shivendra
next prev parent reply other threads:[~2026-06-03 18:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 14:25 [PATCH v22 00/13] Implement PSCI reboot mode driver for PSCI resets Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 01/13] power: reset: reboot-mode: Remove devres based allocations Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 02/13] power: reset: reboot-mode: Add support for 64 bit magic Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 03/13] power: reset: reboot-mode: Add support for predefined reboot modes Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 04/13] firmware: psci: Introduce command-based resets Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 05/13] mfd: psci-mfd: Add PSCI MFD driver for cpuidle-psci-domain cell Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 06/13] dt-bindings: arm: Document reboot mode magic Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 07/13] power: reset: Add psci-reboot-mode driver Shivendra Pratap
2026-05-18 8:58 ` Bartosz Golaszewski
2026-05-18 16:45 ` Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 08/13] mfd: core: Add firmware-node support to MFD cells Shivendra Pratap
2026-05-18 8:57 ` Bartosz Golaszewski
2026-05-18 16:41 ` Shivendra Pratap
2026-05-20 17:51 ` Shivendra Pratap
2026-05-21 11:26 ` Lee Jones
2026-05-21 12:29 ` Bartosz Golaszewski
2026-05-21 13:24 ` Lee Jones
2026-05-21 13:36 ` Bartosz Golaszewski
2026-05-21 16:27 ` Lee Jones
2026-05-22 9:08 ` Bartosz Golaszewski
2026-05-25 9:34 ` Shivendra Pratap
2026-06-03 18:51 ` Shivendra Pratap [this message]
2026-05-14 14:25 ` [PATCH v22 09/13] mfd: psci-mfd: Add psci-reboot-mode child cell Shivendra Pratap
2026-05-18 8:53 ` Bartosz Golaszewski
2026-05-14 14:25 ` [PATCH v22 10/13] arm64: dts: qcom: Add psci reboot-modes for kodiak boards Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 11/13] arm64: dts: qcom: Add psci reboot-modes for lemans boards Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 12/13] arm64: dts: qcom: Add psci reboot-modes for monaco boards Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 13/13] arm64: dts: qcom: Add psci reboot-modes for talos boards Shivendra Pratap
2026-05-29 13:30 ` [PATCH v22 00/13] Implement PSCI reboot mode driver for PSCI resets Shivendra Pratap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81680397-3bbd-4f66-9166-546c8fe753fc@oss.qualcomm.com \
--to=shivendra.pratap@oss$(echo .)qualcomm.com \
--cc=Souvik.Chakravarty@arm$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=andre.draszik@linaro$(echo .)org \
--cc=andy.yan@rock-chips$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bartosz.golaszewski@oss$(echo .)qualcomm.com \
--cc=brgl@kernel$(echo .)org \
--cc=christian.loehle@arm$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=daniel.lezcano@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.baryshkov@oss$(echo .)qualcomm.com \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=john.stultz@linaro$(echo .)org \
--cc=kathiravan.thirumoorthy@oss$(echo .)qualcomm.com \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=lpieralisi@kernel$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=moritz.fischer@ettus$(echo .)com \
--cc=mukesh.ojha@oss$(echo .)qualcomm.com \
--cc=rafael@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=sre@kernel$(echo .)org \
--cc=srini@kernel$(echo .)org \
--cc=sudeep.holla@kernel$(echo .)org \
--cc=ulfh@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox