Re: [PATCH v2 10/22] mtd: spi-nor: Rework write_sr()

From: John Garry <john.garry@huawei•com>
To: "Tudor.Ambarus@microchip•com" <Tudor.Ambarus@microchip•com>,
	"vigneshr@ti•com" <vigneshr@ti•com>,
	"boris.brezillon@collabora•com" <boris.brezillon@collabora•com>,
	"marek.vasut@gmail•com" <marek.vasut@gmail•com>,
	"linux-mtd@lists•infradead.org" <linux-mtd@lists•infradead.org>,
	"geert+renesas@glider•be" <geert+renesas@glider•be>,
	"jonas@norrbonn•se" <jonas@norrbonn•se>
Cc: "linux-aspeed@lists•ozlabs.org" <linux-aspeed@lists•ozlabs.org>,
	"andrew@aj•id.au" <andrew@aj•id.au>,
	"richard@nod•at" <richard@nod•at>,
	"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
	"vz@mleia•com" <vz@mleia•com>,
	"linux-mediatek@lists•infradead.org"
	<linux-mediatek@lists•infradead.org>,
	"joel@jms•id.au" <joel@jms•id.au>,
	"miquel.raynal@bootlin•com" <miquel.raynal@bootlin•com>,
	"matthias.bgg@gmail•com" <matthias.bgg@gmail•com>,
	"computersforpeace@gmail•com" <computersforpeace@gmail•com>,
	"dwmw2@infradead•org" <dwmw2@infradead•org>,
	"linux-arm-kernel@lists•infradead.org"
	<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH v2 10/22] mtd: spi-nor: Rework write_sr()
Date: Fri, 4 Oct 2019 10:39:51 +0100	[thread overview]
Message-ID: <83d62334-bd1c-20b7-3c58-225392c819f8@huawei.com> (raw)
In-Reply-To: <20190924074533.6618-11-tudor.ambarus@microchip.com>

On 24/09/2019 08:46, Tudor.Ambarus@microchip•com wrote:
> +}
> +
> +/**
> + * spi_nor_write_sr() - Write the Status Register.
> + * @nor:	pointer to 'struct spi_nor'.
> + * @sr:		buffer to write to the Status Register.
> + * @len:	number of bytes to write to the Status Register.
> + *
> + * Return: 0 on success, -errno otherwise.
>   */
> -static int write_sr(struct spi_nor *nor, u8 val)
> +static int spi_nor_write_sr(struct spi_nor *nor, const u8 *sr, size_t len)
>  {
> -	nor->bouncebuf[0] = val;
> +	int ret;
> +
> +	ret = spi_nor_write_enable(nor);
> +	if (ret)
> +		return ret;
> +

Hi Tudor,

>  	if (nor->spimem) {
>  		struct spi_mem_op op =
>  			SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_WRSR, 1),
>  				   SPI_MEM_OP_NO_ADDR,
>  				   SPI_MEM_OP_NO_DUMMY,
> -				   SPI_MEM_OP_DATA_IN(1, nor->bouncebuf, 1));

This be SPI_MEM_OP_DATA_OUT() in the current mainline code also, right?

I'm testing my under development driver on top of v5.4-rc1, and 
flash_lock -u is broken.

Cheers,
John

> +				   SPI_MEM_OP_DATA_OUT(len, sr, 1));
>
> -		return spi_mem_exec_op(nor->spimem, &op);
> +		ret = spi_mem_exec_op(nor->spimem, &op);
> +	} else {
> +		ret = nor->controller_ops->write_reg(nor, SPINOR_OP_WRSR,
> +						     sr, len);
>  	}
>
> -	return nor->controller_ops->write_reg(nor, SPINOR_OP_WRSR,
> -					      nor->bouncebuf, 1);
> +	if (ret) {
> +		dev_err(nor->dev, "error while writing Status Register\n");
> +		return ret;
> +	}
> +
> +	ret = spi_nor_wait_till_ready(nor);
> +
> +	return ret;
>  }
>
>  static struct spi_nor *mtd_to_spi_nor(struct mtd_info *mtd)
> @@ -741,161 +914,6 @@ static int winbond_set_4byte(struct spi_nor *nor, bool enable)
>  	return ret;
>  }

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel