From: Krzysztof Kozlowski <krzk@kernel•org>
To: "Gregor Herburger" <gregor.herburger@linutronix•de>,
"Rob Herring" <robh@kernel•org>,
"Krzysztof Kozlowski" <krzk+dt@kernel•org>,
"Conor Dooley" <conor+dt@kernel•org>,
"Florian Fainelli" <florian.fainelli@broadcom•com>,
"Ray Jui" <rjui@broadcom•com>,
"Scott Branden" <sbranden@broadcom•com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom•com>,
"Eric Anholt" <eric@anholt•net>,
"Stefan Wahren" <wahrenst@gmx•net>,
"Srinivas Kandagatla" <srini@kernel•org>,
"Kees Cook" <kees@kernel•org>,
"Gustavo A. R. Silva" <gustavoars@kernel•org>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix•de>
Cc: devicetree@vger•kernel.org, linux-rpi-kernel@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-hardening@vger•kernel.org,
Conor Dooley <conor.dooley@microchip•com>
Subject: Re: [PATCH v5 7/8] dt-bindings: raspberrypi,bcm2835-firmware: Drop unnecessary select
Date: Thu, 21 May 2026 09:11:48 +0200 [thread overview]
Message-ID: <8454c168-97e2-4cd1-8279-a92916a6471d@kernel.org> (raw)
In-Reply-To: <20260520-rpi-otp-driver-v5-7-b26e5908eeac@linutronix.de>
On 20/05/2026 16:27, Gregor Herburger wrote:
> The select schema is not necessary because the
> raspberrypi,bcm2835-firmware compatible is already matched by the
> compatible string values.
This is wrong. The select was not because of that. Select was needed
because of simple-mfd, but dtschema was changed, so please rephrase:
The "select" in schema is not necessary anymore since dtschema drops
simple-mfd when constructing the select/filter query for schemas with
compatibles.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-21 7:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 14:27 [PATCH v5 0/8] nvmem: Add Raspberry Pi OTP nvmem driver Gregor Herburger
2026-05-20 14:27 ` [PATCH v5 1/8] soc: bcm2835: Use IS_REACHABLE for function declaration Gregor Herburger
2026-05-21 14:32 ` Thomas Weißschuh
2026-05-20 14:27 ` [PATCH v5 2/8] nvmem: core: Enforce stride and alignment checks for nvmem_device functions Gregor Herburger
2026-05-21 14:32 ` Thomas Weißschuh
2026-05-20 14:27 ` [PATCH v5 3/8] dt-bindings: raspberrypi,bcm2835-firmware: Add bcm2712-firmware compatible Gregor Herburger
2026-05-20 14:27 ` [PATCH v5 4/8] nvmem: Add the Raspberry Pi OTP driver Gregor Herburger
2026-05-21 14:34 ` Thomas Weißschuh
2026-05-20 14:27 ` [PATCH v5 5/8] firmware: raspberrypi: register nvmem driver Gregor Herburger
2026-05-21 14:38 ` Thomas Weißschuh
2026-05-20 14:27 ` [PATCH v5 6/8] arm64: dts: broadcom: bcm2712: add raspberrypi,bcm2712-firmware compatible Gregor Herburger
2026-05-20 14:27 ` [PATCH v5 7/8] dt-bindings: raspberrypi,bcm2835-firmware: Drop unnecessary select Gregor Herburger
2026-05-21 7:11 ` Krzysztof Kozlowski [this message]
2026-05-20 14:28 ` [PATCH v5 8/8] arm64: defconfig: Enable the raspberrypi otp driver as module Gregor Herburger
2026-05-21 7:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8454c168-97e2-4cd1-8279-a92916a6471d@kernel.org \
--to=krzk@kernel$(echo .)org \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=conor.dooley@microchip$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=eric@anholt$(echo .)net \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=gregor.herburger@linutronix$(echo .)de \
--cc=gustavoars@kernel$(echo .)org \
--cc=kees@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=rjui@broadcom$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=sbranden@broadcom$(echo .)com \
--cc=srini@kernel$(echo .)org \
--cc=thomas.weissschuh@linutronix$(echo .)de \
--cc=wahrenst@gmx$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox