From: b.zolnierkie@samsung•com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V3 2/3] ARM: EXYNOS5: Add Suspend-to-RAM support for 5420
Date: Thu, 08 May 2014 14:24:39 +0200 [thread overview]
Message-ID: <8537431.uXYiuaPHBe@amdc1032> (raw)
In-Reply-To: <1399546368-30537-1-git-send-email-vikas.sajjan@samsung.com>
Hi,
On Thursday, May 08, 2014 04:22:48 PM Vikas Sajjan wrote:
> Adds Suspend-to-RAM support for EXYNOS5420
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung•com>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung•com>
> ---
> arch/arm/mach-exynos/pm.c | 163 ++++++++++++++++++++++++++++++++++-----
> arch/arm/mach-exynos/regs-pmu.h | 2 +
> 2 files changed, 146 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c
> index a7a1b7f..87ccac7 100644
> --- a/arch/arm/mach-exynos/pm.c
> +++ b/arch/arm/mach-exynos/pm.c
[...]
> @@ -280,33 +352,80 @@ static int exynos_pm_central_resume(void)
>
> static void exynos_pm_resume(void)
> {
> + unsigned int tmp;
> + if (soc_is_exynos5420()) {
> + /* Restore the IRAM register cpu state */
> + s3c_pm_do_restore(exynos5420_cpustate_save,
> + ARRAY_SIZE(exynos5420_cpustate_save));
> +
> + regmap_write(pmu_regmap, S5P_CENTRAL_SEQ_OPTION,
> + EXYNOS5420_USE_STANDBY_WFI_ALL);
> + }
> +
> if (exynos_pm_central_resume())
> goto early_wakeup;
>
> - if (!soc_is_exynos5250())
> + if (!(soc_is_exynos5250() || soc_is_exynos5420()))
> exynos_cpu_restore_register();
>
> /* For release retention */
>
> - regmap_write(pmu_regmap, S5P_PAD_RET_MAUDIO_OPTION, (1 << 28));
> - regmap_write(pmu_regmap, S5P_PAD_RET_GPIO_OPTION, (1 << 28));
> - regmap_write(pmu_regmap, S5P_PAD_RET_UART_OPTION, (1 << 28));
> - regmap_write(pmu_regmap, S5P_PAD_RET_MMCA_OPTION, (1 << 28));
> - regmap_write(pmu_regmap, S5P_PAD_RET_MMCB_OPTION, (1 << 28));
> - regmap_write(pmu_regmap, S5P_PAD_RET_EBIA_OPTION, (1 << 28));
> - regmap_write(pmu_regmap, S5P_PAD_RET_EBIB_OPTION, (1 << 28));
> + if (soc_is_exynos5250()) {
Adding a check here for EXYNOS5250 doesn't look correct (the old code
behavior for older EXYNOS SoCs should be preserved).
> + regmap_write(pmu_regmap, S5P_PAD_RET_MAUDIO_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, S5P_PAD_RET_GPIO_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, S5P_PAD_RET_UART_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, S5P_PAD_RET_MMCA_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, S5P_PAD_RET_MMCB_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, S5P_PAD_RET_EBIA_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, S5P_PAD_RET_EBIB_OPTION, (1 << 28));
> + } else if (soc_is_exynos5420()) {
> + regmap_write(pmu_regmap, EXYNOS_PAD_RET_DRAM_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS_PAD_RET_MAUDIO_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS_PAD_RET_JTAG_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS5420_PAD_RET_GPIO_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS5420_PAD_RET_UART_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS5420_PAD_RET_MMCA_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS5420_PAD_RET_MMCB_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS5420_PAD_RET_MMCC_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS5420_PAD_RET_HSI_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS_PAD_RET_EBIA_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS_PAD_RET_EBIB_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS5420_PAD_RET_SPI_OPTION, (1 << 28));
> + regmap_write(pmu_regmap, EXYNOS5420_PAD_RET_DRAM_COREBLK_OPTION, (1 << 28));
> + }
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2014-05-08 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 10:52 [PATCH V3 2/3] ARM: EXYNOS5: Add Suspend-to-RAM support for 5420 Vikas Sajjan
2014-05-08 12:24 ` Bartlomiej Zolnierkiewicz [this message]
2014-05-13 10:14 ` Abhilash Kesavan
2014-05-10 4:31 ` Pankaj Dubey
2014-05-13 10:14 ` Abhilash Kesavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8537431.uXYiuaPHBe@amdc1032 \
--to=b.zolnierkie@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox