Subject: Re: [PATCH] irqchip: Use int type to store negative error codes

From: Marc Zyngier <[email-masked]>
Date: Fri, 29 Aug 2025 16:04:35 +0100

On Fri, 29 Aug 2025 14:20:19 +0100,
Qianfeng Rong <[email-masked]> wrote:
> 
> Change the 'ret' variable from unsigned int to int to store negative error
> codes or zero returned by other functions.
> 
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but it's ugly. Additionally, assigning negative error codes to
> unsigned type may trigger a GCC warning when the -Wsign-conversion flag is
> enabled.
> 
> Signed-off-by: Qianfeng Rong <[email-masked]>

For the GICv3 code:

Acked-by: Marc Zyngier <[email-masked]>

	M.

-- 
Without deviation from the norm, progress is not possible.