* [PATCH V3 0/2 RESEND] ARM: dts: bcm283x: Fix probing of bcm2835-i2s
@ 2018-02-16 10:55 Stefan Wahren
2018-02-16 10:55 ` [PATCH V3 1/2 RESEND] dt-bindings: bcm283x: Fix register ranges " Stefan Wahren
2018-02-16 10:55 ` [PATCH V3 2/2 RESEND] ARM: dts: bcm283x: Fix probing " Stefan Wahren
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Wahren @ 2018-02-16 10:55 UTC (permalink / raw)
To: linux-arm-kernel
This small series fixes the probing of bcm2835-i2s, which is broken
since 517e7a1537a ("ASoC: bcm2835: move to use the clock framework").
Changes in V3:
* split up patch into dt-binding and functional part
Changes in V2:
* add Fixes, Reviewed-by and Tested-by tags
Stefan Wahren (2):
dt-bindings: bcm283x: Fix register ranges of bcm2835-i2s
ARM: dts: bcm283x: Fix probing of bcm2835-i2s
Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt | 4 ++--
Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt | 9 ++++-----
arch/arm/boot/dts/bcm283x.dtsi | 4 ++--
3 files changed, 8 insertions(+), 9 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH V3 1/2 RESEND] dt-bindings: bcm283x: Fix register ranges of bcm2835-i2s 2018-02-16 10:55 [PATCH V3 0/2 RESEND] ARM: dts: bcm283x: Fix probing of bcm2835-i2s Stefan Wahren @ 2018-02-16 10:55 ` Stefan Wahren 2018-02-19 19:35 ` Rob Herring 2018-02-16 10:55 ` [PATCH V3 2/2 RESEND] ARM: dts: bcm283x: Fix probing " Stefan Wahren 1 sibling, 1 reply; 5+ messages in thread From: Stefan Wahren @ 2018-02-16 10:55 UTC (permalink / raw) To: linux-arm-kernel Since 517e7a1537a ("ASoC: bcm2835: move to use the clock framework") the bcm2835-i2s requires a clock as DT property. Unfortunately the necessary DT change has never been applied. While we are at it also fix the first PCM register range to cover the PCM_GRAY register. This patch only fixes the affected dt-bindings. Signed-off-by: Stefan Wahren <stefan.wahren@i2se•com> Reviewed-by: Eric Anholt <eric@anholt•net> --- Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt | 4 ++-- Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt | 9 ++++----- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt index baf9b34..b6a8cc0 100644 --- a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt +++ b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt @@ -74,8 +74,8 @@ Example: bcm2835_i2s: i2s at 7e203000 { compatible = "brcm,bcm2835-i2s"; - reg = < 0x7e203000 0x20>, - < 0x7e101098 0x02>; + reg = < 0x7e203000 0x24>; + clocks = <&clocks BCM2835_CLOCK_PCM>; dmas = <&dma 2>, <&dma 3>; diff --git a/Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt b/Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt index 65783de..7bb0362 100644 --- a/Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt +++ b/Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt @@ -2,9 +2,8 @@ Required properties: - compatible: "brcm,bcm2835-i2s" -- reg: A list of base address and size entries: - * The first entry should cover the PCM registers - * The second entry should cover the PCM clock registers +- reg: Should contain PCM registers location and length. +- clocks: the (PCM) clock to use - dmas: List of DMA controller phandle and DMA request line ordered pairs. - dma-names: Identifier string for each DMA request line in the dmas property. These strings correspond 1:1 with the ordered pairs in dmas. @@ -16,8 +15,8 @@ Example: bcm2835_i2s: i2s at 7e203000 { compatible = "brcm,bcm2835-i2s"; - reg = <0x7e203000 0x20>, - <0x7e101098 0x02>; + reg = <0x7e203000 0x24>; + clocks = <&clocks BCM2835_CLOCK_PCM>; dmas = <&dma 2>, <&dma 3>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH V3 1/2 RESEND] dt-bindings: bcm283x: Fix register ranges of bcm2835-i2s 2018-02-16 10:55 ` [PATCH V3 1/2 RESEND] dt-bindings: bcm283x: Fix register ranges " Stefan Wahren @ 2018-02-19 19:35 ` Rob Herring 0 siblings, 0 replies; 5+ messages in thread From: Rob Herring @ 2018-02-19 19:35 UTC (permalink / raw) To: linux-arm-kernel On Fri, Feb 16, 2018 at 11:55:33AM +0100, Stefan Wahren wrote: > Since 517e7a1537a ("ASoC: bcm2835: move to use the clock framework") > the bcm2835-i2s requires a clock as DT property. Unfortunately > the necessary DT change has never been applied. While we are at it > also fix the first PCM register range to cover the PCM_GRAY register. > > This patch only fixes the affected dt-bindings. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se•com> > Reviewed-by: Eric Anholt <eric@anholt•net> > --- > Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt | 4 ++-- > Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt | 9 ++++----- > 2 files changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Rob Herring <robh@kernel•org> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V3 2/2 RESEND] ARM: dts: bcm283x: Fix probing of bcm2835-i2s 2018-02-16 10:55 [PATCH V3 0/2 RESEND] ARM: dts: bcm283x: Fix probing of bcm2835-i2s Stefan Wahren 2018-02-16 10:55 ` [PATCH V3 1/2 RESEND] dt-bindings: bcm283x: Fix register ranges " Stefan Wahren @ 2018-02-16 10:55 ` Stefan Wahren 2018-02-22 20:11 ` Eric Anholt 1 sibling, 1 reply; 5+ messages in thread From: Stefan Wahren @ 2018-02-16 10:55 UTC (permalink / raw) To: linux-arm-kernel Since 517e7a1537a ("ASoC: bcm2835: move to use the clock framework") the bcm2835-i2s requires a clock as DT property. Unfortunately the necessary DT change has never been applied. While we are at it also fix the first PCM register range to cover the PCM_GRAY register. Fixes: 517e7a1537a ("ASoC: bcm2835: move to use the clock framework") Signed-off-by: Stefan Wahren <stefan.wahren@i2se•com> Reviewed-by: Eric Anholt <eric@anholt•net> Tested-by: Matthias Reichl <hias@horus•com> --- arch/arm/boot/dts/bcm283x.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi index 013431e..e08203c 100644 --- a/arch/arm/boot/dts/bcm283x.dtsi +++ b/arch/arm/boot/dts/bcm283x.dtsi @@ -396,8 +396,8 @@ i2s: i2s at 7e203000 { compatible = "brcm,bcm2835-i2s"; - reg = <0x7e203000 0x20>, - <0x7e101098 0x02>; + reg = <0x7e203000 0x24>; + clocks = <&clocks BCM2835_CLOCK_PCM>; dmas = <&dma 2>, <&dma 3>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH V3 2/2 RESEND] ARM: dts: bcm283x: Fix probing of bcm2835-i2s 2018-02-16 10:55 ` [PATCH V3 2/2 RESEND] ARM: dts: bcm283x: Fix probing " Stefan Wahren @ 2018-02-22 20:11 ` Eric Anholt 0 siblings, 0 replies; 5+ messages in thread From: Eric Anholt @ 2018-02-22 20:11 UTC (permalink / raw) To: linux-arm-kernel Stefan Wahren <stefan.wahren@i2se•com> writes: > Since 517e7a1537a ("ASoC: bcm2835: move to use the clock framework") > the bcm2835-i2s requires a clock as DT property. Unfortunately > the necessary DT change has never been applied. While we are at it > also fix the first PCM register range to cover the PCM_GRAY register. > > Fixes: 517e7a1537a ("ASoC: bcm2835: move to use the clock framework") > Signed-off-by: Stefan Wahren <stefan.wahren@i2se•com> > Reviewed-by: Eric Anholt <eric@anholt•net> > Tested-by: Matthias Reichl <hias@horus•com> I've applied these 2 to bcm2835-dt-next. Thanks! -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 832 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180222/8929bc37/attachment.sig> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-22 20:11 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-02-16 10:55 [PATCH V3 0/2 RESEND] ARM: dts: bcm283x: Fix probing of bcm2835-i2s Stefan Wahren 2018-02-16 10:55 ` [PATCH V3 1/2 RESEND] dt-bindings: bcm283x: Fix register ranges " Stefan Wahren 2018-02-19 19:35 ` Rob Herring 2018-02-16 10:55 ` [PATCH V3 2/2 RESEND] ARM: dts: bcm283x: Fix probing " Stefan Wahren 2018-02-22 20:11 ` Eric Anholt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox