From: khilman@linaro•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 3/3] ARM: OMAP4+: Remove static iotable mappings for SRAM
Date: Thu, 29 Aug 2013 10:20:25 -0700 [thread overview]
Message-ID: <871u5c2z3a.fsf@linaro.org> (raw)
In-Reply-To: <1377775391-13103-4-git-send-email-rnayak@ti.com> (Rajendra Nayak's message of "Thu, 29 Aug 2013 16:53:11 +0530")
Rajendra Nayak <rnayak@ti•com> writes:
> In order to handle errata I688, a page of sram was reserved by doing a
> static iotable map. Now that we use gen_pool to manage sram, we can
> completely remove all of these static mappings and use gen_pool_alloc()
> to get the one page of sram space needed to implement errata I688.
>
> Suggested-by: Sekhar Nori <nsekhar@ti•com>
> Signed-off-by: Rajendra Nayak <rnayak@ti•com>
[...]
> @@ -71,6 +72,21 @@ void omap_bus_sync(void)
> }
> EXPORT_SYMBOL(omap_bus_sync);
>
> +static int __init omap4_sram_init(void)
> +{
> + struct device_node *np;
> + struct gen_pool *sram_pool;
> +
> + np = of_find_compatible_node(NULL, NULL, "ti,omap4-mpu");
> + if (!np)
> + pr_warn("%s:Unable to allocate sram needed to handle errata I688\n",
> + __func__);
> + sram_pool = of_get_named_gen_pool(np, "sram", 0);
I haven't actually tested this, but if there is no 'sram' property defined...
> + sram_sync = (void *)gen_pool_alloc(sram_pool, PAGE_SIZE);
... does this still behave properly?
> + return 0;
> +}
Kevin
next prev parent reply other threads:[~2013-08-29 17:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 11:23 [PATCH v2 0/3] OMAP4+: Get rid of internal SRAM handling Rajendra Nayak
2013-08-29 11:23 ` [PATCH v2 1/3] ARM: AM335x: Get rid of unused sram init function Rajendra Nayak
2013-08-29 11:23 ` [PATCH v2 2/3] ARM: OMAP4+: Move SRAM data to DT Rajendra Nayak
2013-08-29 13:26 ` Sekhar Nori
2013-08-29 13:31 ` Santosh Shilimkar
2013-08-29 13:44 ` Sekhar Nori
2013-08-29 13:48 ` Santosh Shilimkar
2013-08-29 13:50 ` Rajendra Nayak
2013-08-29 13:51 ` Santosh Shilimkar
2013-09-02 17:03 ` Sekhar Nori
2013-09-03 13:37 ` Sekhar Nori
2013-08-29 11:23 ` [PATCH v2 3/3] ARM: OMAP4+: Remove static iotable mappings for SRAM Rajendra Nayak
2013-08-29 13:23 ` Santosh Shilimkar
2013-08-29 13:56 ` Rajendra Nayak
2013-08-29 17:20 ` Kevin Hilman [this message]
2013-08-29 17:25 ` Santosh Shilimkar
2013-08-30 9:27 ` Rajendra Nayak
2013-08-30 14:39 ` Kevin Hilman
2013-08-30 14:41 ` Santosh Shilimkar
2013-08-29 13:24 ` [PATCH v2 0/3] OMAP4+: Get rid of internal SRAM handling Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u5c2z3a.fsf@linaro.org \
--to=khilman@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox