From: khilman@linaro•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: fix missing flush_kernel_dcache_page() for noMMU
Date: Thu, 20 Jun 2013 07:30:54 -0700 [thread overview]
Message-ID: <871u7w6eht.fsf@linaro.org> (raw)
In-Reply-To: <1371672910-9340-1-git-send-email-gmbnomis@gmail.com> (Simon Baatz's message of "Wed, 19 Jun 2013 22:15:10 +0200")
Simon Baatz <gmbnomis@gmail•com> writes:
> Commit 1bc3974 moved the implementation of flush_kernel_dcache_page()
> into in mm/flush.c but did not implement it on noMMU ARM.
>
> Signed-off-by: Simon Baatz <gmbnomis@gmail•com>
> Cc: <stable@vger•kernel.org> # 3.2+: 1bc3974: ARM: 7755/1
> Cc: <stable@vger•kernel.org> # 3.2+
> ---
>
> ARM 7755/1 "handle user space mapped pages in flush_kernel_dcache_page"
> unfortunately broke the no MMU case. Compile tested with allnoconfig and
> at91x40_defconfig on v3.10-rc6/v3.9.6 + ARM 7755/1. On older stable kernels
> (3.2.47 & 3.4.49) compiled with at91x40_defconfig.
Acked-by: Kevin Hilman <khilman@linaro•org>
This fix is needed in linux-next also, which started failing
allnoconfig builds since next-20130619.
Kevin
>
> - Simon
>
> arch/arm/mm/nommu.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
> index d51225f..eb5293a 100644
> --- a/arch/arm/mm/nommu.c
> +++ b/arch/arm/mm/nommu.c
> @@ -57,6 +57,12 @@ void flush_dcache_page(struct page *page)
> }
> EXPORT_SYMBOL(flush_dcache_page);
>
> +void flush_kernel_dcache_page(struct page *page)
> +{
> + __cpuc_flush_dcache_area(page_address(page), PAGE_SIZE);
> +}
> +EXPORT_SYMBOL(flush_kernel_dcache_page);
> +
> void copy_to_user_page(struct vm_area_struct *vma, struct page *page,
> unsigned long uaddr, void *dst, const void *src,
> unsigned long len)
next prev parent reply other threads:[~2013-06-20 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 20:15 [PATCH] ARM: fix missing flush_kernel_dcache_page() for noMMU Simon Baatz
2013-06-19 21:15 ` Sergei Shtylyov
2013-06-20 14:30 ` Kevin Hilman [this message]
2013-06-23 8:09 ` Simon Baatz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u7w6eht.fsf@linaro.org \
--to=khilman@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox