Subject: Re: [PATCH 1/3] irqchip/gic-v5: Move LPI alloc/free into LPI domain

From: Thomas Gleixner <[email-masked]>
Date: Tue, 05 May 2026 22:02:43 +0200

On Thu, Apr 30 2026 at 15:34, Sascha Bischoff wrote:

> Rather than relying on the domains built on top of GICv5's LPI domain
> to manage LPI allocations and frees, move that into the LPI domain
> itself. This, rightly, ensures that domains other than the LPI itself
> have no knowledge of LPI allocations themselves. This not only cleans
> up the LPI domain itself, but also the IPI and ITS MSI domains which
> build upon it.
>
> While we're at it, drop the helpers wrapping the helpers -
> gicv5_alloc_lpi() and gicv5_free_lpi() - and directly use alloc_lpi()
> and release_lpi() instead.

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog

>  
> +static void gicv5_irq_lpi_domain_free(struct irq_domain *domain, unsigned int virq,
> +				      unsigned int nr_irqs)
> +{
> +	struct irq_data *d;
> +
> +	if (WARN_ON_ONCE(nr_irqs != 1))
> +		return;
> +
> +	d = irq_domain_get_irq_data(domain, virq);
> +
> +

Stray extra newline.

> +	release_lpi(d->hwirq);
> +
> +	irq_set_handler(virq, NULL);
> +	irq_domain_reset_irq_data(d);
> +}

Otherwise this looks good.