From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] bus: mvebu-mbus: Provide stub function for mvebu_mbus_get_io_win_info()
Date: Wed, 31 Aug 2016 17:23:00 +0200 [thread overview]
Message-ID: <8737lleze3.fsf@free-electrons.com> (raw)
In-Reply-To: <093e5ca1-d22a-166e-6d3f-573498ab8c93@denx.de> (Stefan Roese's message of "Mon, 29 Aug 2016 19:40:26 +0200")
Hi Stefan,
On lun., ao?t 29 2016, Stefan Roese <sr@denx•de> wrote:
> Hi Gregory,
>
> On 29.08.2016 16:02, Gregory CLEMENT wrote:
>> On lun., ao?t 29 2016, Andrew Lunn <andrew@lunn•ch> wrote:
>>
>>> On Mon, Aug 29, 2016 at 01:04:55PM +0200, Stefan Roese wrote:
>>>> This patch provides a stub function for mvebu_mbus_get_io_win_info(),
>>>> which will be used for all non-Orion (ARM32 MVEBU) platforms for
>>>> compile test coverage.
>>>>
>>>> Signed-off-by: Stefan Roese <sr@denx•de>
>>>> Cc: Gregory CLEMENT <gregory.clement@free-electrons•com>
>>>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
>>>> Cc: Marcin Wojtas <mw@semihalf•com>
>>>> Cc: Arnd Bergmann <arnd@arndb•de>
>>>> Cc: Vinod Koul <vinod.koul@intel•com>
>>>> ---
>>>> include/linux/mbus.h | 9 +++++++--
>>>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/include/linux/mbus.h b/include/linux/mbus.h
>>>> index d610232..a884405 100644
>>>> --- a/include/linux/mbus.h
>>>> +++ b/include/linux/mbus.h
>>>> @@ -55,6 +55,8 @@ struct mbus_dram_target_info
>>>> #ifdef CONFIG_PLAT_ORION
>>>> extern const struct mbus_dram_target_info *mv_mbus_dram_info(void);
>>>> extern const struct mbus_dram_target_info *mv_mbus_dram_info_nooverlap(void);
>>>> +int mvebu_mbus_get_io_win_info(phys_addr_t phyaddr, u32 *size, u8 *target,
>>>> + u8 *attr);
>>>> #else
>>>> static inline const struct mbus_dram_target_info *mv_mbus_dram_info(void)
>>>> {
>>>> @@ -64,14 +66,17 @@ static inline const struct mbus_dram_target_info *mv_mbus_dram_info_nooverlap(vo
>>>> {
>>>> return NULL;
>>>> }
>>>> +static inline int mvebu_mbus_get_io_win_info(phys_addr_t phyaddr, u32 *size,
>>>> + u8 *target, u8 *attr)
>>>> +{
>>>> + return 0;
>>>> +}
>>>> #endif
>>>
>>> Hi Stefan
>>>
>>> If i understand it correctly, this should never be used for real, it
>>> is here only for compile testing?
>>>
>>> Maybe add a WARN_ON_ONCE(1) here? And a comment, why it should never
>>> happen.
>>
>> Actually arm64 mvebu SoC such as the Armada 3700 do not have mbus bus
>> but can still reuse the same driver than the other mvebu SoC. So in
>> this case I would prefer that the function return an error.
>
> I missed thinking about Armada 3700 while adding this IO (PCIe) support
> to the XOR DMA driver. Most likely because the Armada 3700 support was
> added after I started working on this IO (non SDRAM) DMA support for
> Armada XP.
>
> Its probably not possible to support these IO (PCIe) areas on Armada
> 3700 this way without any information from the MBus mapping as
> possible for the other ARM32 SoCs. So its perhaps best if I just
> disable this "feature" for Armada 3700 for now.
>
> What do you think?
My concern to return an error with mbus was not for the XOR
driver. It was the neta driver that I had in mind (which was not
converted yet).
Thanks,
Gregory
>
> Thanks,
> Stefan
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2016-08-31 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 11:04 [PATCH 1/2] bus: mvebu-mbus: Provide stub function for mvebu_mbus_get_io_win_info() Stefan Roese
2016-08-29 11:04 ` [PATCH 2/2 v3] dmaengine: mv_xor: Add support for IO (PCIe) src/dst areas Stefan Roese
2016-08-29 12:57 ` [PATCH 1/2] bus: mvebu-mbus: Provide stub function for mvebu_mbus_get_io_win_info() Andrew Lunn
2016-08-29 13:54 ` Stefan Roese
2016-08-29 14:02 ` Gregory CLEMENT
2016-08-29 14:57 ` Andrew Lunn
2016-08-29 17:40 ` Stefan Roese
2016-08-31 15:23 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737lleze3.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox