public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: bpringlemeir@nbsps•com (Bill Pringlemeir)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv2 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
Date: Tue, 29 Jul 2014 14:56:41 -0400	[thread overview]
Message-ID: <8738dkuh7a.fsf@nbsps.com> (raw)
In-Reply-To: <1395627736-5338-3-git-send-email-Li.Xiubo@freescale.com> (Xiubo Li's message of "Mon, 24 Mar 2014 10:22:15 +0800")

On 23 Mar 2014, Li.Xiubo at freescale.com wrote:

> Signed-off-by: Xiubo Li <Li.Xiubo@freescale•com>
> ---
> arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-twr.dts
> b/arch/arm/boot/dts/vf610-twr.dts index f3af8ea..3fabdb5 100644 ---
> a/arch/arm/boot/dts/vf610-twr.dts +++
> b/arch/arm/boot/dts/vf610-twr.dts @@ -213,6 +213,17 @@
> 			>;
> 		};
>
> + pinctrl_pwm0: pwm0grp { + fsl,pins = < + VF610_PAD_PTB0__FTM0_CH0

Hi Xiubo,

I think you added this for the tower audio board?  Maybe the beeper?
Are these lines needed?

+	VF610_PAD_PTB6__FTM0_CH6		0x1582
+	VF610_PAD_PTB7__FTM0_CH7		0x1582

According to my tower schematics, PTB6 routes to the Primary B35/GPIO4,
and B40/FTM0CH6/PWM4 and to the jumpers J23.  PTB7 routes to
B39/FTM0CH7/PWM5, EIRQ3/B55/B56, and jumper J24.  I think that most
people have some tower serial card which can also route these lines
and/or they are sent to the OpenSDA chip which does a ttyACM (USB
serial) on all Tower main boards.

Did you just add all FTM channels 0-7 in the DTS?  Or are each and every
one mapped to a pin on the expansion/riser boards.  Could we remove the
two lines above and use,

	pinctrl_uart2: uart2grp {
		fsl,pins = <
                        VF610_PAD_PTB6__UART2_TX                0x21a2
                        VF610_PAD_PTB7__UART2_RX                0x21a1
		>;
	};

So that the PTB6/7 map to UART2?  Or are these indeed a conflict with
some audio board (or other)?  I think it might be valuable to add the
'ttyLP2' to the vf610-twr.  An MMC image could echo 'wrong serial port,
set J23/24' for instance to tell people that the serial console was not
connected properly (or something else).  People may also wish to use a
serial interface for other peripherals or as a 2nd debug port.

Thanks,
Bill Pringlemeir.

next prev parent reply	other threads:[~2014-07-29 18:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24  2:22 [PATCHv2 0/3] Add DTS node for FTM PWM Xiubo Li
2014-03-24  2:22 ` [PATCHv2 1/3] ARM: dts: vf610: Add Freescale FTM PWM node Xiubo Li
2014-03-24  2:22 ` [PATCHv2 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node Xiubo Li
2014-07-29 18:56   ` Bill Pringlemeir [this message]
2014-07-30  2:11     ` Li.Xiubo at freescale.com
2014-07-30  2:58       ` Shawn Guo
2014-03-24  2:22 ` [PATCHv2 3/3] ARM: dts: vf610-twr: Enables FTM PWM device Xiubo Li
2014-03-24  4:36 ` [PATCHv2 0/3] Add DTS node for FTM PWM Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738dkuh7a.fsf@nbsps.com \
    --to=bpringlemeir@nbsps$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox