From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH-V2 3/4] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals
Date: Tue, 08 May 2012 15:38:09 -0700 [thread overview]
Message-ID: <87397ajo32.fsf@ti.com> (raw)
In-Reply-To: <1336506724-5494-4-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Wed, 9 May 2012 01:22:03 +0530")
Vaibhav Hiremath <hvaibhav@ti•com> writes:
> The function __omap2_set_globals() can be common across all
> platforms/architectures, even in case of omap4, internally it
> calls same set of functions as in __omap2_set_globals() function
> (except for sdrc).
OK so far.
> This patch adds new config flag SOC_HAS_OMAP2_SDRC to handle sdrc,
> so that we can reuse same function across omap2/3/4...
But what happens when a single kernel is built that has support for an
SoC with an SDRC (OMAP4) and one that doesn't (AM33xx)?
In that case this new SOC_HAS_OMAP2_SDRC will be set, and
set_globals_sdrc() will be called even for the SoCs without SDRC.
So, rather than add a new Kconfig option for this, I would rather see
you using the existing runtime feature check for the SDRC: omap_has_sdrc()
Kevin
next prev parent reply other threads:[~2012-05-08 22:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 19:52 [PATCH-V2 0/4] ARM: OMAP2+: Cleanup series in order to remove ARCH_OMAPx dependency Vaibhav Hiremath
2012-05-08 19:52 ` [PATCH-V2 1/4] ARM: OMAP2+: CLEANUP: All OMAP2PLUS uses omap-device.o target so add one entry Vaibhav Hiremath
2012-05-08 19:52 ` [PATCH-V2 2/4] ARM: OMAP2+: CLEANUP: Move omap3 dpll ops to dpll3xxx.c Vaibhav Hiremath
2012-05-10 23:02 ` Paul Walmsley
2012-05-11 7:01 ` Hiremath, Vaibhav
2012-05-08 19:52 ` [PATCH-V2 3/4] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals Vaibhav Hiremath
2012-05-08 22:38 ` Kevin Hilman [this message]
2012-05-09 8:59 ` Hiremath, Vaibhav
2012-05-10 21:39 ` Kevin Hilman
2012-05-11 6:09 ` Hiremath, Vaibhav
2012-05-11 6:37 ` Sricharan R
2012-05-11 6:43 ` Hiremath, Vaibhav
2012-05-11 21:54 ` Kevin Hilman
2012-05-14 9:23 ` Hiremath, Vaibhav
2012-05-08 19:52 ` [PATCH-V2 4/4] ARM: OMAP2+: CLEANUP: Add new config option for different DPLL features Vaibhav Hiremath
2012-05-08 22:50 ` Kevin Hilman
2012-05-09 9:06 ` Hiremath, Vaibhav
2012-05-10 22:35 ` Paul Walmsley
2012-05-11 5:30 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87397ajo32.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox