From: Miquel Raynal <miquel.raynal@bootlin•com>
To: Richard Genoud <richard.genoud@bootlin•com>
Cc: Richard Weinberger <richard@nod•at>,
Vignesh Raghavendra <vigneshr@ti•com>,
Chen-Yu Tsai <wens@csie•org>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Samuel Holland <samuel@sholland•org>,
Wentao Liang <vulab@iscas•ac.cn>,
Maxime Ripard <mripard@kernel•org>,
Boris Brezillon <bbrezillon@kernel•org>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
linux-mtd@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-sunxi@lists•linux.dev, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2 5/6] mtd: rawnand: sunxi: make the code mode self-explanatory
Date: Mon, 09 Mar 2026 17:50:16 +0100 [thread overview]
Message-ID: <874impne0n.fsf@bootlin.com> (raw)
In-Reply-To: <20260305100137.2558423-6-richard.genoud@bootlin.com> (Richard Genoud's message of "Thu, 5 Mar 2026 11:01:36 +0100")
On 05/03/2026 at 11:01:36 +01, Richard Genoud <richard.genoud@bootlin•com> wrote:
In the title: s/mode/more/?
> In sunxi_nfc_hw_ecc_{read,write}_chunk(), the ECC step was force to 0,
forced!
> the reason is not trivial to get when reading the code.
>
> The explanation is that, from the NAND flash controller perspective, we
> are indeed at step 0 for user data length and ECC errors.
>
> Just add a const value with an explanation to clarify things.
>
next prev parent reply other threads:[~2026-03-09 16:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 10:01 [PATCH v2 0/6] mtd: rawnand: sunxi: Fixes user data length for H6 Richard Genoud
2026-03-05 10:01 ` [PATCH v2 1/6] mtd: rawnand: sunxi: sunxi_nand_ooblayout_free code clarification Richard Genoud
2026-03-14 8:05 ` Chen-Yu Tsai
2026-03-05 10:01 ` [PATCH v2 2/6] mtd: rawnand: sunxi: fix sunxi_nfc_hw_ecc_read_extra_oob Richard Genoud
2026-03-05 10:01 ` [PATCH v2 3/6] mtd: rawnand: sunxi: do not count BBM bytes twice Richard Genoud
2026-03-09 15:27 ` Miquel Raynal
2026-03-12 10:39 ` Richard GENOUD
2026-03-05 10:01 ` [PATCH v2 4/6] mtd: rawnand: sunxi: replace hard coded value by a define - take2 Richard Genoud
2026-03-05 10:01 ` [PATCH v2 5/6] mtd: rawnand: sunxi: make the code mode self-explanatory Richard Genoud
2026-03-09 16:50 ` Miquel Raynal [this message]
2026-03-12 10:47 ` Richard GENOUD
2026-03-05 10:01 ` [PATCH v2 6/6] mtd: rawnand: sunxi: introduce variable user data length Richard Genoud
2026-03-12 14:41 ` Miquel Raynal
2026-03-13 13:17 ` Richard GENOUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874impne0n.fsf@bootlin.com \
--to=miquel.raynal@bootlin$(echo .)com \
--cc=bbrezillon@kernel$(echo .)org \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=mripard@kernel$(echo .)org \
--cc=richard.genoud@bootlin$(echo .)com \
--cc=richard@nod$(echo .)at \
--cc=samuel@sholland$(echo .)org \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
--cc=vulab@iscas$(echo .)ac.cn \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox