From: robert.jarzmik@free•fr (Robert Jarzmik)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp
Date: Wed, 26 Nov 2014 23:12:13 +0100 [thread overview]
Message-ID: <874mtl3936.fsf@free.fr> (raw)
In-Reply-To: <87d28d3uh5.fsf@free.fr> (Robert Jarzmik's message of "Mon, 24 Nov 2014 08:53:26 +0100")
OK Dmitry, I pulled through, the interrupts are working back.
Actually one of the blockers I have is in pxa25x_udc, and it is also in your
phy-lubbock.c. The bottom of the error is that disable_irq() is called from
within a irq handler, and it deadlocks. A disable_irq_nosync() should be used
...
... but a better approach would be to use a threaded irq for vbus handling. I
think that way disable_irq() can be used, no workqueue is needed anymore in
phy-lubbock.
Would you make that change, I'll test it and review it.
Cheers.
--
Robert
next prev parent reply other threads:[~2014-11-26 22:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 15:07 [PATCH V2 1/5] serial: pxa: prepare/unprepare clocks Dmitry Eremin-Solenikov
2014-11-17 15:07 ` [PATCH V2 2/5] i2c: " Dmitry Eremin-Solenikov
2014-11-17 15:51 ` Russell King - ARM Linux
2014-11-17 18:26 ` Wolfram Sang
2014-11-17 15:07 ` [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp Dmitry Eremin-Solenikov
2014-11-17 18:44 ` Robert Jarzmik
2014-11-17 20:05 ` Dmitry Eremin-Solenikov
2014-11-17 20:07 ` Russell King - ARM Linux
2014-11-17 20:09 ` Robert Jarzmik
2014-11-17 23:50 ` Dmitry Eremin-Solenikov
2014-11-19 20:29 ` Robert Jarzmik
2014-11-19 21:11 ` Dmitry Eremin-Solenikov
2014-11-22 13:56 ` Robert Jarzmik
2014-11-22 15:44 ` Dmitry Eremin-Solenikov
2014-11-22 17:18 ` Robert Jarzmik
2014-11-22 17:48 ` Dmitry Eremin-Solenikov
2014-11-22 17:49 ` Robert Jarzmik
2014-11-22 17:51 ` Dmitry Eremin-Solenikov
2014-11-24 7:53 ` Robert Jarzmik
2014-11-26 22:12 ` Robert Jarzmik [this message]
2014-11-26 22:19 ` Dmitry Eremin-Solenikov
[not found] ` <87zjbd1tb0.fsf_-_@free.fr>
2014-11-26 22:39 ` Lubbock interrupts fix (was lubbock udc phy) Dmitry Eremin-Solenikov
2014-11-18 15:49 ` [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp Felipe Balbi
2014-11-17 15:07 ` [PATCH V2 4/5] mfd: t7l66xb: prepare/unprepare clocks Dmitry Eremin-Solenikov
2014-11-18 13:14 ` Lee Jones
2014-11-17 15:07 ` [PATCH V2 5/5] mfd: tc6387xb: " Dmitry Eremin-Solenikov
2014-11-18 12:04 ` Lee Jones
2014-11-17 15:51 ` [PATCH V2 1/5] serial: pxa: " Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mtl3936.fsf@free.fr \
--to=robert.jarzmik@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox