From: arno@natisbad•org (Arnaud Ebalard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv2 5/8] arm: mvebu: add common uart0 and spi0 pintcrl entries for Armada 370
Date: Sun, 16 Nov 2014 23:29:00 +0100 [thread overview]
Message-ID: <874mtyok43.fsf@natisbad.org> (raw)
In-Reply-To: <20141116211034.GJ15870@lunn.ch> (Andrew Lunn's message of "Sun, 16 Nov 2014 22:10:34 +0100")
Hi,
Andrew Lunn <andrew@lunn•ch> writes:
> On Sun, Nov 16, 2014 at 06:37:33PM +0100, Arnaud Ebalard wrote:
>>
>> pinctrl entries for uart0 using MPP0-1 and spi0 using MPP33-36 are
>> common configurations. Instead of replicating them in each .dts file,
>> put those in armada-370.dtsi file so that they can be referenced.
>>
>> Suggested-by: Andrew Lunn <andrew@lunn•ch>
>> Signed-off-by: Arnaud Ebalard <arno@natisbad•org>
>> ---
>> arch/arm/boot/dts/armada-370.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
>> index 6b3c23b1e138..d9f5d59e463e 100644
>> --- a/arch/arm/boot/dts/armada-370.dtsi
>> +++ b/arch/arm/boot/dts/armada-370.dtsi
>> @@ -115,6 +115,17 @@
>> compatible = "marvell,mv88f6710-pinctrl";
>> reg = <0x18000 0x38>;
>>
>> + uart0_pins: uart0-pins {
>> + marvell,pins = "mpp0", "mpp1";
>> + marvell,function = "uart0";
>> + };
>
> Thanks for these.
>
> We can go one stage further. kirkwood.dts has:
>
> uart0: serial at 12000 {
> compatible = "ns16550a";
> reg = <0x12000 0x100>;
> reg-shift = <2>;
> interrupts = <33>;
> clocks = <&gate_clk 7>;
> pinctrl-0 = <&pmx_uart0>;
> pinctrl-names = "default";
> status = "disabled";
> };
>
> i.e actually references them. This is safe because a board .dts file
> can override the pins if needed.
>
> We should do the same here, both for 370 and XP.
Just to be sure I understand: for uart0 and uart1, I think this can only
be done for Armada 370 (on XP, uart0/1 rx/tx are not mpp).
This only a matter of adding the following in armada-370.dtsi for uart0:
/*
* Default UART pinctrl setting without RTS/CTS, can
* be overwritten on board level.
*/
uart0: serial at 12000 {
pinctrl-0 = <&uart0_pins>;
pinctrl-names = "default";
};
For uart1, it's not obvious because there are 6 different MPP which can
be configured to act as uart1 TXD. Same for RXD. If I remove the ones
overlapping w/ RGMII pins for GbE interfaces, which one should be
selected as default: 41/42, 55/57, 60/61?
Now, regarding armada XP, uart2 and uart3 txd/rxd MPP are 42/43 and
44/45. Best we can do is put the same as above in each specific
armada-xp-mv78XXX.dtsi file, where pinctrl node is, after adding
uart2-pins and uart3-pins. Unless I am missing something, this cannot
be done in armada-xp.dtsi.
Cheers,
a+
next prev parent reply other threads:[~2014-11-16 22:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 17:36 [PATCHv2 0/8] arm: mvebu: add Synology DS213j and DS414 .dts files Arnaud Ebalard
2014-11-16 17:36 ` [PATCHv2 1/8] of: add "micron" vendor prefix for Micron Arnaud Ebalard
2014-11-16 17:37 ` [PATCHv2 2/8] arm: mvebu: fix vendor prefix typo in kirkwood-synology.dtsi Arnaud Ebalard
2014-11-16 21:00 ` Andrew Lunn
2014-11-16 17:37 ` [PATCHv2 3/8] arm: mvebu: add uartX labels for Armada SoC serial nodes Arnaud Ebalard
2014-11-16 17:37 ` [PATCHv2 4/8] arm: mvebu: use recently introduced uart label for stdout-path Arnaud Ebalard
2014-11-16 21:02 ` Andrew Lunn
2014-11-16 17:37 ` [PATCHv2 5/8] arm: mvebu: add common uart0 and spi0 pintcrl entries for Armada 370 Arnaud Ebalard
2014-11-16 21:10 ` Andrew Lunn
2014-11-16 22:29 ` Arnaud Ebalard [this message]
2014-11-17 0:55 ` Andrew Lunn
2014-11-17 9:28 ` Sebastian Hesselbarth
2014-11-16 17:37 ` [PATCHv2 6/8] arm: mvebu: add common ge0/1 and spi0 pintcrl entries for Armada XP MV78230 Arnaud Ebalard
2014-11-16 17:37 ` [PATCHv2 7/8] arm: mvebu: add .dts file for Synology DS213j Arnaud Ebalard
2014-11-17 1:29 ` Andrew Lunn
2014-11-17 8:48 ` Arnaud Ebalard
2014-11-16 17:38 ` [PATCHv2 8/8] arm: mvebu: add .dts file for Synology DS414 Arnaud Ebalard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mtyok43.fsf@natisbad.org \
--to=arno@natisbad$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox