From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 2/3] omap_twl: Prevent SR to enable for am3517/am3505 devices
Date: Fri, 30 Sep 2011 16:27:03 -0700 [thread overview]
Message-ID: <874nztfw6w.fsf@ti.com> (raw)
In-Reply-To: <87r52xhhkb.fsf@ti.com> (Kevin Hilman's message of "Fri, 30 Sep 2011 14:00:04 -0700")
Abhilash,
Kevin Hilman <khilman@ti•com> writes:
> Abhilash K V <abhilash.kv@ti•com> writes:
>
>> From: Abhilash K V <abhilash.kv@ti•com>
>>
>> In case of AM3517 & AM3505, SmartReflex is not applicable so
>> we must not enable it. So omap3_twl_init() is now not called
>> when the processor does not support SR.
>
> This still isn't right.
>
> The reason to skip the TWL PMIC init is not because SR is not available
> (TWL PMICs are quite usable without SR). The reason to skip TWL PMIC
> init is because the PMIC is not present.
>
> Instead, we need to fix up the TWL/PMIC init so that TWL-specifics are
> only registered if a TWL driver is registered.
>
Below is a test patch that is a first pass at implementing what I
suggested above. I tested this (along with your patch 3/3) on a
3430/n900 after removing the omap_pmic_init() call frome the board file.
Can you let me know if this solves the problem you're seeing on
platforms that don't have TWL PMICs?
After digging into this more, I'm increasingly aware that the way we're
managing the init of PMIC stuff is a mess. Guess I need another round
of voltage layer cleanups to fix that up.
Kevin
next prev parent reply other threads:[~2011-09-30 23:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 6:12 [PATCH v5 0/3] AM3517: Booting up Abhilash K V
2011-09-30 6:12 ` [PATCH v5 1/3] AM35x: Using OMAP3 generic hwmods Abhilash K V
2011-09-30 6:12 ` [PATCH v5 2/3] omap_twl: Prevent SR to enable for am3517/am3505 devices Abhilash K V
2011-09-30 6:12 ` [PATCH v5 3/3] OMAP2+: voltage: add check for missing PMIC info in vp init Abhilash K V
2011-09-30 18:41 ` Paul Walmsley
2011-09-30 22:14 ` Kevin Hilman
2011-09-30 21:10 ` Kevin Hilman
2011-09-30 21:00 ` [PATCH v5 2/3] omap_twl: Prevent SR to enable for am3517/am3505 devices Kevin Hilman
2011-09-30 23:27 ` Kevin Hilman [this message]
2011-10-11 7:59 ` Koyamangalath, Abhilash
2011-10-11 17:40 ` Kevin Hilman
2011-09-30 8:17 ` [PATCH v5 1/3] AM35x: Using OMAP3 generic hwmods Paul Walmsley
2011-10-07 9:12 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nztfw6w.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox