From: khilman@deeprootsystems•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] OMAP: features: export symbol omap3_features
Date: Fri, 24 Sep 2010 07:58:09 -0700 [thread overview]
Message-ID: <874odfkx32.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1285299665-21639-1-git-send-email-omar.ramirez@ti.com> (Omar Ramirez Luna's message of "Thu, 23 Sep 2010 22:41:04 -0500")
Omar Ramirez Luna <omar.ramirez@ti•com> writes:
> From: Kevin Hilman <khilman@deeprootsystems•com>
Minor nit, can you make the subject something like:
OMAP: features: make feature checks available to modules
Thanks,
Kevin
> Since omap3_features is a global variable, only code
> built-in the kernel can make use of it and thus use
> omap_has ##feat functions; exporting this as a kernel
> symbol makes modules able to use feature detection
> framework too.
>
> Thread: http://marc.info/?l=linux-omap&m=128528822902211&w=2
>
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems•com>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti•com>
> CC: Tony Lindgren <tony@atomide•com>
> CC: Russell King <linux@arm•linux.org.uk>
> CC: Nishanth Menon <nm@ti•com>
> CC: Paul Walmsley <paul@pwsan•com>
> CC: Sanjeev Premi <premi@ti•com>
> CC: linux-omap at vger.kernel.org
> CC: linux-arm-kernel at lists.infradead.org
> ---
> arch/arm/mach-omap2/id.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index 9a879f9..a8c6d19 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -31,6 +31,7 @@ static struct omap_chip_id omap_chip;
> static unsigned int omap_revision;
>
> u32 omap3_features;
> +EXPORT_SYMBOL(omap3_features);
>
> unsigned int omap_rev(void)
> {
next prev parent reply other threads:[~2010-09-24 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 3:41 [PATCH 1/2] OMAP: features: export symbol omap3_features Omar Ramirez Luna
2010-09-24 14:58 ` Kevin Hilman [this message]
2010-09-24 15:34 ` Paul Walmsley
2010-09-24 16:51 ` Nishanth Menon
2010-09-24 17:06 ` Paul Walmsley
2010-09-24 17:17 ` Paul Walmsley
2010-09-24 17:26 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874odfkx32.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox