From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 4/5] arm64: dts: marvell: Add definition of SPI controller for Armada 3700
Date: Wed, 30 Nov 2016 15:55:29 +0100 [thread overview]
Message-ID: <877f7lm2zi.fsf@free-electrons.com> (raw)
In-Reply-To: <20161130094351.2748-5-romain.perier@free-electrons.com> (Romain Perier's message of "Wed, 30 Nov 2016 10:43:50 +0100")
Hi Romain,
On mer., nov. 30 2016, Romain Perier <romain.perier@free-electrons•com> wrote:
> Armada 3700 SoC has an SPI Controller, this commit adds the definition
> of the SPI device node at the SoC level.
>
> Signed-off-by: Romain Perier <romain.perier@free-electrons•com>
> ---
>
> Changes in v2:
> - Removed properties max-frequency and clock-frequency, it is no
> longer required and not used by the DT-bindings.
>
> arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index e9bd587..63c2002 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -98,6 +98,17 @@
> /* 32M internal register @ 0xd000_0000 */
> ranges = <0x0 0x0 0xd0000000 0x2000000>;
>
> + spi0: spi at 10600 {
> + compatible = "marvell,armada-3700-spi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x10600 0x5d>;
The last register is at the offset 0x1065C but according tot he
datasheet the range address associated to this IP is from 0x10600 to
0x10FFF.
In the first case the size of the register set should be 0x60 (each
register is 32-bits). But I prefer that we register the full range so a
size of 0xA00.
Thanks,
Gregory
> + clocks = <&nb_periph_clk 7>;
> + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> + num-cs = <4>;
> + status = "disabled";
> + };
> +
> uart0: serial at 12000 {
> compatible = "marvell,armada-3700-uart";
> reg = <0x12000 0x400>;
> --
> 2.9.3
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2016-11-30 14:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 9:43 [PATCH v2 0/5] Add support for the Armada 3700 SPI controller Romain Perier
2016-11-30 9:43 ` [PATCH v2 1/5] spi: Add basic support for Armada 3700 SPI Controller Romain Perier
2016-11-30 9:43 ` [PATCH v2 2/5] spi: armada-3700: Add support for the FIFO mode Romain Perier
2016-11-30 15:15 ` Gregory CLEMENT
2016-11-30 9:43 ` [PATCH v2 3/5] dt-bindings: spi: Add documentation for the Armada 3700 SPI Controller Romain Perier
2016-12-05 23:27 ` Rob Herring
2016-11-30 9:43 ` [PATCH v2 4/5] arm64: dts: marvell: Add definition of SPI controller for Armada 3700 Romain Perier
2016-11-30 14:55 ` Gregory CLEMENT [this message]
2016-11-30 9:43 ` [PATCH v2 5/5] arm64: dts: marvell: Enable spi0 on the board Armada-3720-db Romain Perier
2016-11-30 14:30 ` [PATCH v2 0/5] Add support for the Armada 3700 SPI controller Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f7lm2zi.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox