Subject: [PATCH 03/10] ARM: marvell/dt: add crypto related nodes to armada 370 dtsi

From: [email-masked] (Gregory CLEMENT)
Date: Thu, 27 Aug 2015 17:28:00 +0200

Hi Boris and Arnaud,

Boris Brezillon <[email-masked]> writes:

> From: Arnaud Ebalard <[email-masked]>
>
> Add crypto related nodes in armada-370.dtsi.
[...]
> +
> +			crypto at 90000 {
> +				compatible = "marvell,armada-370-crypto";
> +				reg = <0x90000 0x10000>;
> +				reg-names = "regs";
> +				interrupts = <48>;
> +				clocks = <&gateclk 23>;
> +				clock-names = "cesa0";
> +				marvell,crypto-srams = <&crypto_sram>;
> +				marvell,crypto-sram-size = <0x7e0>;
> +			};
> +		};
> +
> +		crypto_sram: sa-sram {
> +			compatible = "mmio-sram";
> +			reg = <MBUS_ID(0x09, 0x01) 0 0x800>;
> +			reg-names = "sram";
> +			clocks = <&gateclk 23>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0 MBUS_ID(0x09, 0x01) 0 0x800>;
> +
> +			idle-sram at 0 {
> +				reg = <0x0 0x20>;
> +			};

So you think at the cpuilde hack using the sram. And you reserved 32
bytes for it. So indeed it is enough to store the code we need. Could
you add a little comment about it ?

In mvebu_setup_boot_addr_wa we use mvebu_mbus_add_window_by_id but this
windows was also added by the code you add. I wonder if it could be a
problem.

Maybe we should look for if the idle-sram is present and in this case
not calling mvebu_mbus_add_window_by_id, but it is not necessary for
this series.

Once you have added the comment you can add my
Acked-by: Gregory CLEMENT <[email-masked]>

Thanks,

Gregory
-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com