From: khilman@linaro•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] ARM: Kconfig: allow virt CPU accounting
Date: Thu, 01 Aug 2013 17:29:00 -0700 [thread overview]
Message-ID: <877gg5szoz.fsf@linaro.org> (raw)
In-Reply-To: <20130719161708.GB21752@somewhere> (Frederic Weisbecker's message of "Fri, 19 Jul 2013 18:17:10 +0200")
Frederic Weisbecker <fweisbec@gmail•com> writes:
> On Wed, Jul 03, 2013 at 11:36:41AM -0700, Kevin Hilman wrote:
>> With the 64-bit requirement removed from virt CPU accounting,
>> allow ARM platforms to enable it.
>>
>> Cc: Russell King <rmk+kernel@arm•linux.org.uk>
>> Signed-off-by: Kevin Hilman <khilman@linaro•org>
>> ---
>> arch/arm/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 136f263..7850612 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -61,6 +61,7 @@ config ARM
>> select OLD_SIGSUSPEND3
>> select OLD_SIGACTION
>> select HAVE_CONTEXT_TRACKING
>> + select HAVE_VIRT_CPU_ACCOUNTING
>
> I think you got confused here. HAVE_VIRT_CPU_ACCOUNTING is the arch capability
> for VIRT_CPU_ACCOUNTING_NATIVE, not for VIRT_CPU_ACCOUNTING_GEN that only requires
> support for context tracking.
Yes, I am confused. :/
> That's my bad, all those names start to be confusing now.
> The VIRT based Kconfig naming is a bit weird, that doesn't really reflect what the feature
> is doing. "Virtual cputime accounting" just doesn't give any clue, except perhaps suggesting
> the stuff deals with virtualization while it actually has nothing to do with.
> I don't even know what virtual refers to here.
>
> Same goes for vtime based APIs. In fact I just based my work on the legacy that was
> there and expanded further the non-sense ;-)
>
> I'll need to do a big renaming one day.
>
> But to begin with I should rename s/HAVE_VIRT_CPU_ACCOUNTING/HAVE_VIRT_CPU_ACCOUNTING_NATIVE.
OK, I just tested and I can indeed drop this patch.
Thanks for clarifying,
Kevin
next prev parent reply other threads:[~2013-08-02 0:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 18:36 [PATCH 0/3] nohz/full: final Kconfig bits for ARM support Kevin Hilman
2013-07-03 18:36 ` [PATCH 1/3] nohz: Kconfig: remove redundant 64-bit dependency Kevin Hilman
2013-07-19 16:29 ` Frederic Weisbecker
2013-07-03 18:36 ` [PATCH 2/3] init/Kconfig: VIRT_CPU_ACCOUNTING_GEN: drop 64-bit requirement Kevin Hilman
2013-07-19 16:51 ` Frederic Weisbecker
2013-07-03 18:36 ` [PATCH 3/3] ARM: Kconfig: allow virt CPU accounting Kevin Hilman
2013-07-19 16:17 ` Frederic Weisbecker
2013-08-02 0:29 ` Kevin Hilman [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-20 23:34 [PATCH 0/3] ARM: context tracking support prerequisites Kevin Hilman
2013-03-20 23:34 ` [PATCH 3/3] ARM: Kconfig: allow virt CPU accounting Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gg5szoz.fsf@linaro.org \
--to=khilman@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox