Subject: [PATCH v5 03/14] KVM: ARM: Initial skeleton to compile KVM support

From: [email-masked] (Rusty Russell)
Date: Wed, 16 Jan 2013 13:26:01 +1030

Christoffer Dall <[email-masked]> writes:

> On Mon, Jan 14, 2013 at 11:24 AM, Russell King - ARM Linux
> <[email-masked]> wrote:
>> On Tue, Jan 08, 2013 at 01:38:55PM -0500, Christoffer Dall wrote:
>>> +     /* -ENOENT for unknown features, -EINVAL for invalid combinations. */
>>> +     for (i = 0; i < sizeof(init->features)*8; i++) {
>>> +             if (init->features[i / 32] & (1 << (i % 32))) {
>>
>> Isn't this an open-coded version of test_bit() ?
>
> indeed, nicely spotted:

BTW, I wrote it that was out of excessive paranoia: it's a userspace
API, and test_bit() won't be right on 64 bit BE systems.

Cheers,
Rusty.