From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 08/14] ARM: OMAP3+: hwmod: add SmartReflex IRQs
Date: Tue, 28 Feb 2012 14:47:22 -0800 [thread overview]
Message-ID: <877gz6k22t.fsf@ti.com> (raw)
In-Reply-To: <1328723039-15952-9-git-send-email-j-pihet@ti.com> (Jean Pihet's message of "Wed, 8 Feb 2012 18:43:53 +0100")
Jean Pihet <jean.pihet@newoldbits•com> writes:
> From: Nishanth Menon <nm@ti•com>
>
> OMAP3 SmartReflex IRQs in hwmod structures with the same naming as
> present in OMAP4. Without these IRQs being registered, SmartReflex
> driver will be unable to get the IRQ numbers to handle notifications
>
> Signed-off-by: Nishanth Menon <nm@ti•com>
> Signed-off-by: Jean Pihet <j-pihet@ti•com>
> ---
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index 8688960..eef31cb 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -377,6 +377,16 @@ static struct omap_hwmod_ocp_if omap3_l4_core__i2c3 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +static struct omap_hwmod_irq_info omap3_smartreflex_mpu_irqs[] = {
> + { .name = "sr1_irq", .irq = 18},
> + { .irq = -1 }
> +};
> +
> +static struct omap_hwmod_irq_info omap3_smartreflex_core_irqs[] = {
> + { .name = "sr2_irq", .irq = 19},
> + { .irq = -1 }
> +};
minor: I don't think the .name field is required here since there's only
one, and the driver does not use get_resource_by_name().
Kevin
> /* L4 CORE -> SR1 interface */
> static struct omap_hwmod_addr_space omap3_sr1_addr_space[] = {
> {
> @@ -2689,6 +2699,7 @@ static struct omap_hwmod omap34xx_sr1_hwmod = {
> .slaves = omap3_sr1_slaves,
> .slaves_cnt = ARRAY_SIZE(omap3_sr1_slaves),
> .dev_attr = &sr1_dev_attr,
> + .mpu_irqs = omap3_smartreflex_mpu_irqs,
> .flags = HWMOD_SET_DEFAULT_CLOCKACT,
> };
>
> @@ -2708,6 +2719,7 @@ static struct omap_hwmod omap36xx_sr1_hwmod = {
> .slaves = omap3_sr1_slaves,
> .slaves_cnt = ARRAY_SIZE(omap3_sr1_slaves),
> .dev_attr = &sr1_dev_attr,
> + .mpu_irqs = omap3_smartreflex_mpu_irqs,
> };
>
> /* SR2 */
> @@ -2735,6 +2747,7 @@ static struct omap_hwmod omap34xx_sr2_hwmod = {
> .slaves = omap3_sr2_slaves,
> .slaves_cnt = ARRAY_SIZE(omap3_sr2_slaves),
> .dev_attr = &sr2_dev_attr,
> + .mpu_irqs = omap3_smartreflex_core_irqs,
> .flags = HWMOD_SET_DEFAULT_CLOCKACT,
> };
>
> @@ -2754,6 +2767,7 @@ static struct omap_hwmod omap36xx_sr2_hwmod = {
> .slaves = omap3_sr2_slaves,
> .slaves_cnt = ARRAY_SIZE(omap3_sr2_slaves),
> .dev_attr = &sr2_dev_attr,
> + .mpu_irqs = omap3_smartreflex_core_irqs,
> };
>
> /*
next prev parent reply other threads:[~2012-02-28 22:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 17:43 [PATCH v4 00/14] ARM: OMAP3+: SmartReflex: bugfixes and clean-ups Jean Pihet
2012-02-08 17:43 ` [PATCH 01/14] ARM: OMAP3+: SmartReflex: Layer Cleanup [V4] Jean Pihet
2012-02-28 22:37 ` Kevin Hilman
2012-02-08 17:43 ` [PATCH 02/14] ARM: OMAP3+: SmartReflex: fix err interrupt disable sequence Jean Pihet
2012-02-08 17:43 ` [PATCH 03/14] ARM: OMAP3+: SmartReflex Class3: disable errorgen before disable VP Jean Pihet
2012-02-08 17:43 ` [PATCH 04/14] ARM: OMAP3+: SmartReflex: Add a shutdown hook Jean Pihet
2012-02-28 22:40 ` Kevin Hilman
2012-02-28 22:59 ` Menon, Nishanth
2012-02-29 18:07 ` Kevin Hilman
2012-02-29 23:33 ` Jean Pihet
2012-02-08 17:43 ` [PATCH 05/14] ARM: OMAP3+: SmartReflex: use __devexit_p annotation Jean Pihet
2012-02-08 17:43 ` [PATCH 06/14] ARM: OMAP3+: SmartReflex: Fix status masking in ERRCONFIG register Jean Pihet
2012-02-08 17:43 ` [PATCH 07/14] ARM: OMAP3+: SmartReflex: clear ERRCONFIG_VPBOUNDINTST only on a need Jean Pihet
2012-02-08 17:43 ` [PATCH 08/14] ARM: OMAP3+: hwmod: add SmartReflex IRQs Jean Pihet
2012-02-28 22:47 ` Kevin Hilman [this message]
2012-02-08 17:43 ` [PATCH 09/14] ARM: OMAP3+: SmartReflex: add missing platform_set_drvdata() Jean Pihet
2012-02-08 17:43 ` [PATCH 10/14] ARM: OMAP3+: SmartReflex: move late_initcall() closer to its argument Jean Pihet
2012-02-08 17:43 ` [PATCH 11/14] ARM: OMAP3+: SmartReflex: misc cleanups Jean Pihet
2012-02-08 17:43 ` [PATCH 12/14] ARM: OMAP3+: SmartReflex: micro-optimization for sanity check Jean Pihet
2012-02-08 17:43 ` [PATCH 13/14] ARM: OMAP3+: SmartReflex: fix the use of debugfs_create_* API Jean Pihet
2012-02-08 17:43 ` [PATCH 14/14] ARM: OMAP3+: SmartReflex: fix error handling Jean Pihet
2012-02-28 22:50 ` [PATCH v4 00/14] ARM: OMAP3+: SmartReflex: bugfixes and clean-ups Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gz6k22t.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox