From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v7 16/21] OMAP2+: UART: Remove custom activate funcs and use generic funcs.
Date: Fri, 04 Nov 2011 15:00:14 -0700 [thread overview]
Message-ID: <877h3f5z0x.fsf@ti.com> (raw)
In-Reply-To: <1318952110-10659-2-git-send-email-govindraj.raja@ti.com> (Govindraj R.'s message of "Tue, 18 Oct 2011 21:05:07 +0530")
"Govindraj.R" <govindraj.raja@ti•com> writes:
> The custom hwmod activate and deactivate funcs does hwmod_enable
> and idle same can be done with omap_device generic API's.
>
> Signed-off-by: Govindraj.R <govindraj.raja@ti•com>
This one needs a minor update for current mainline...
> ---
> arch/arm/mach-omap2/serial.c | 18 ++----------------
> 1 files changed, 2 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index 7c65410..7658a03 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -78,24 +78,10 @@ static struct omap_uart_port_info omap_serial_default_info[] __initdata = {
> },
> };
>
> -static int uart_idle_hwmod(struct omap_device *od)
> -{
> - omap_hwmod_idle(od->hwmods[0]);
> -
> - return 0;
> -}
> -
> -static int uart_enable_hwmod(struct omap_device *od)
> -{
> - omap_hwmod_enable(od->hwmods[0]);
> -
> - return 0;
> -}
> -
> static struct omap_device_pm_latency omap_uart_latency[] = {
> {
> - .deactivate_func = uart_idle_hwmod,
> - .activate_func = uart_enable_hwmod,
> + .activate_func = omap_device_enable_hwmods,
> + .deactivate_func = omap_device_idle_hwmods,
> .flags = OMAP_DEVICE_LATENCY_AUTO_ADJUST,
> },
> };
If we're just using default pm_latency struct, it can be passed to
omap_device_build as NULL, and a default one will be configured.
Kevin
next prev parent reply other threads:[~2011-11-04 22:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 15:35 [PATCH v7 15/21] OMAP2+: UART: Make the RX_TIMEOUT for DMA configurable for each UART Govindraj.R
2011-10-18 15:35 ` [PATCH v7 16/21] OMAP2+: UART: Remove custom activate funcs and use generic funcs Govindraj.R
2011-11-04 22:00 ` Kevin Hilman [this message]
2011-11-07 8:39 ` Govindraj
2011-10-18 15:35 ` [PATCH v7 17/21] OMAP2+: UART: Remove omap_uart_can_sleep and add pm_qos Govindraj.R
2011-11-04 22:42 ` Kevin Hilman
2011-11-08 9:16 ` Rajendra Nayak
2011-11-08 19:20 ` Kevin Hilman
2011-11-10 12:00 ` Govindraj
2011-11-10 19:02 ` Kevin Hilman
2011-11-11 10:17 ` Govindraj
2011-10-18 15:35 ` [PATCH v7 18/21] OMAP2+: UART: remove temporary variable used to count uart instance Govindraj.R
2011-10-18 15:35 ` [PATCH v7 19/21] OMAP2+: UART: Use custom activate func for console uart Govindraj.R
2011-11-04 23:00 ` Kevin Hilman
2011-11-07 8:42 ` Govindraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877h3f5z0x.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox