From: rusty@rustcorp•com.au (Rusty Russell)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC 1/2] virtio: Add AMBA bus driver for virtio device
Date: Mon, 12 Sep 2011 11:01:14 +0930 [thread overview]
Message-ID: <877h5e5yxp.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1314966257-7503-2-git-send-email-pawel.moll@arm.com>
On Fri, 2 Sep 2011 13:24:16 +0100, Pawel Moll <pawel.moll@arm•com> wrote:
> This patch, based on virtio PCI driver, adds support for virtio
> AMBA device. This should allow environments like qemu to use
> virtio-based block & network devices.
Cool work! I like the concept, but a few implementation notes below:
> + * offset width name description
> + * ------ ----- ------------- -----------------
> + *
> + * 0x000 32 HostFeatures Features supported by the host
> + * 0x004 32 GuestFeatures Features activated by the guest
You need to make these at least 64 bits. Lguest makes them variable
width, in fact.
> + * 0x008 32 QueuePFN PFN for the currently selected queue
> + * 0x00c 32 QueueNum Queue size for the currently selected queue
You should, I believe, seriously consider allowing the guest to set the
queue size, rather than the host (perhaps the host could suggest one,
but the guest should be able to override it).
Anthony or Michael might suggest other changes, since they are most
familiar with virtio_pci limitations...
Cheers,
Rusty.
next prev parent reply other threads:[~2011-09-12 1:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 12:24 [RFC 0/2] Memory mapped virtio device Pawel Moll
[not found] ` <1314966257-7503-2-git-send-email-pawel.moll@arm.com>
2011-09-12 1:31 ` Rusty Russell [this message]
2011-09-12 16:45 ` [RFC 1/2] virtio: Add AMBA bus driver for " Pawel Moll
[not found] ` <1315846301-13892-1-git-send-email-pawel.moll@arm.com>
2011-09-12 17:27 ` [RFC v2] arm: Add platform " Anthony Liguori
2011-09-13 8:58 ` Pawel Moll
2011-09-13 2:58 ` [RFC 1/2] virtio: Add AMBA " Rusty Russell
2011-09-13 9:40 ` Pawel Moll
2011-09-14 0:18 ` Rusty Russell
2011-09-14 16:47 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877h5e5yxp.fsf@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox