From: robert.jarzmik@free•fr (Robert Jarzmik)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] pxa/mioa701: use gpio arrays for global and gsm gpio initialization
Date: Thu, 28 Apr 2011 09:10:58 +0200 [thread overview]
Message-ID: <877haeetq5.fsf@free.fr> (raw)
In-Reply-To: <BANLkTinE3Rubb4Kr-JqT_6ep-LNwLmTd5A@mail.gmail.com> (Eric Miao's message of "Mon\, 25 Apr 2011 11\:31\:12 +0800")
Eric Miao <eric.y.miao@gmail•com> writes:
> On Fri, Apr 22, 2011 at 6:35 PM, pHilipp Zabel <philipp.zabel@gmail•com> wrote:
>> On Thu, Apr 21, 2011 at 11:33 PM, Robert Jarzmik <robert.jarzmik@free•fr> wrote:
>>> Philipp Zabel <philipp.zabel@gmail•com> writes:
>>>
>>>> gpio_request_arrays() / gpio_free_arrays() are functional replacements for
>>>> mio_gpio_request() / mio_gpio_free(), which are now obsolete.
>>>>
>>>> Signed-off-by: Philipp Zabel <philipp.zabel@gmail•com>
>>>
>>> Acked-by: Robert Jarzmik <robert.jarzmik@free•fr>
>>
>> Dmitry Artamonow pointed out that contrary to
>> hx4700/mio_gpio_request(), gpio_request_array() is silent when a
>> request fails. Would you prefer something like
>>
>> int rc;
>> rc = gpio_request_array(ARRAY_AND_SIZE(global_gpios));
>> if (rc)
>> ? ?pr_err("MioA701: Failed to request GPIOs.\n");
>>
>> in there?
>>
>
> That will always be good.
Indeed.
pHilipp, keep the ack, the usage of gpio_request_array() is a very good
idea. Reporting the error is even better than saying nothing.
Cheers.
--
Robert
next prev parent reply other threads:[~2011-04-28 7:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 19:55 [PATCH] pxa/mioa701: use gpio arrays for global and gsm gpio initialization Philipp Zabel
2011-04-21 21:33 ` Robert Jarzmik
2011-04-22 10:35 ` pHilipp Zabel
2011-04-25 3:31 ` Eric Miao
2011-04-27 18:50 ` [PATCH v2] " Philipp Zabel
2011-04-28 7:10 ` Robert Jarzmik [this message]
2011-04-28 20:19 ` [PATCH v3] " Philipp Zabel
2011-07-05 7:55 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877haeetq5.fsf@free.fr \
--to=robert.jarzmik@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox