From: arnaud.patard@rtp-net•org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists•infradead.org
Subject: [patch 8/9] efikamx: add spi nor support
Date: Wed, 20 Oct 2010 19:55:55 +0200 [thread overview]
Message-ID: <877hhciw9g.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <AANLkTi=a75BNTitznSU6QQ+5mSvwYicsftPvgMKWzZ-z@mail.gmail.com> (Matt Sealey's message of "Wed\, 20 Oct 2010 12\:36\:56 -0500")
Matt Sealey <matt@genesi-usa•com> writes:
> On Wed, Oct 20, 2010 at 6:26 AM, Amit Kucheria <amit.kucheria@linaro•org> wrote:
>> On 10 Oct 19, Arnaud Patard wrote:
>>> On efikamx, uboot is stored on a nor spi flash. Add support for it
>>>
>>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net•org>
>>> Index: linux-2.6/arch/arm/mach-mx5/board-mx51_efikamx.c
>>> ===================================================================
>>> --- linux-2.6.orig/arch/arm/mach-mx5/board-mx51_efikamx.c ? ? 2010-10-16 14:21:24.000000000 +0200
>>> +++ linux-2.6/arch/arm/mach-mx5/board-mx51_efikamx.c ?2010-10-16 15:34:12.000000000 +0200
>>> @@ -24,6 +24,8 @@
>>> ?#include <linux/delay.h>
>>> ?#include <linux/io.h>
>>> ?#include <linux/fsl_devices.h>
>>> +#include <linux/spi/flash.h>
>>> +#include <linux/spi/spi.h>
>>>
>>> ?#include <mach/common.h>
>>> ?#include <mach/hardware.h>
>>> @@ -52,6 +54,9 @@
>>>
>>> ?#define EFIKAMX_POWER_KEY ? ?(1*32+31)
>>>
>>> +#define EFIKAMX_SPI_CS0 ? ? ? ? ? ? ?(3*32+24)
>>> +#define EFIKAMX_SPI_CS1 ? ? ? ? ? ? ?(3*32+25)
>>
>> It is just a style thing, but could you make this (3*32 + 24). Makes it
>> easier on the eyes to read "4th gpio bank, 24th pin"
>
> Better yet:
>
> #define GPIO_BANK(n) ((n-1)*32)
> ..
> #define EFIKAMX_SPI_CS0 (GPIO_BANK(4) + 24).
>
> It'll get compiled to a constant and is more readable, right? :D
you can even imagine something like
#define MX51_GPIO(x,y) ((x-1) + y)
Anyway, imho it should be a different patch because if we're going this
way all imx51 machines files would deserve the same change.
>
>>> ?/* the pci ids pin have pull up. they're driven low according to board id */
>>> ?#define MX51_PAD_PCBID0 ? ? ?IOMUX_PAD(0x518, 0x130, 3, 0x0, ? 0, PAD_CTL_PUS_100K_UP)
>>> ?#define MX51_PAD_PCBID1 ? ? ?IOMUX_PAD(0x51C, 0x134, 3, 0x0, ? 0, PAD_CTL_PUS_100K_UP)
>>> @@ -99,6 +104,14 @@
>>>
>>> ? ? ? /* power key */
>>> ? ? ? MX51_PAD_PWRKEY,
>>> +
>>> + ? ? /* spi */
>>> + ? ? MX51_PAD_CSPI1_MOSI__ECSPI1_MOSI,
>>> + ? ? MX51_PAD_CSPI1_MISO__ECSPI1_MISO,
>>> + ? ? MX51_PAD_CSPI1_SS0__GPIO_4_24,
>>> + ? ? MX51_PAD_CSPI1_SS1__GPIO_4_25,
>>> + ? ? MX51_PAD_CSPI1_RDY__ECSPI1_RDY,
>>> + ? ? MX51_PAD_CSPI1_SCLK__ECSPI1_SCLK,
>>> ?};
>>>
>>> ?/* Serial ports */
>>> @@ -252,6 +265,47 @@
>>> ? ? ? },
>>> ?};
>>>
>>> +static struct mtd_partition mx51_efikamx_spi_nor_partitions[] = {
>>> + ? ? {
>>> + ? ? ?.name = "u-boot",
>>
>> "bootloader" ?
>
> "firmware" :)
please, reach an agreement with Amit. I don't want to be blocked by such
a thing :)
Arnaud
next prev parent reply other threads:[~2010-10-20 17:55 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 20:42 [patch 0/9] efikamx support improvements Arnaud Patard (Rtp)
2010-10-19 20:42 ` [patch 1/9] efikamx: read board id Arnaud Patard (Rtp)
2010-10-19 21:15 ` Sascha Hauer
2010-10-19 21:30 ` Matt Sealey
2010-10-20 7:54 ` Amit Kucheria
2010-10-20 8:12 ` Arnaud Patard (Rtp)
2010-10-20 9:03 ` Amit Kucheria
2010-10-20 8:24 ` Sascha Hauer
2010-10-20 8:35 ` Arnaud Patard (Rtp)
2010-10-20 8:59 ` Matt Sealey
2010-10-20 9:16 ` Uwe Kleine-König
2010-10-20 17:26 ` Matt Sealey
2010-10-20 19:26 ` Loïc Minier
2010-10-20 19:53 ` Arnaud Patard (Rtp)
2010-10-21 1:32 ` Matt Sealey
2010-10-20 20:53 ` Matt Sealey
2010-10-19 20:42 ` [patch 2/9] efikamx: add mmc support Arnaud Patard (Rtp)
2010-10-19 20:42 ` [patch 3/9] imx51: enhance/fix iomux configuration Arnaud Patard (Rtp)
2010-10-19 21:04 ` Sascha Hauer
2010-10-20 8:14 ` Arnaud Patard (Rtp)
2010-10-20 9:14 ` Eric Bénard
2010-10-20 9:26 ` Arnaud Patard (Rtp)
2010-10-20 9:18 ` Eric Bénard
2010-10-20 9:29 ` Arnaud Patard (Rtp)
2010-10-20 9:41 ` Amit Kucheria
2010-10-20 10:00 ` Uwe Kleine-König
2010-10-20 10:12 ` Arnaud Patard (Rtp)
2010-10-20 12:10 ` Uwe Kleine-König
2010-10-19 20:42 ` [patch 4/9] imx51: add gpio mode for csi1 {h,v}sync Arnaud Patard (Rtp)
2010-10-19 20:42 ` [patch 5/9] efikamx: add leds support Arnaud Patard (Rtp)
2010-10-20 11:15 ` Amit Kucheria
2010-10-19 20:42 ` [patch 6/9] efikamx: add support for power key Arnaud Patard (Rtp)
2010-10-19 20:43 ` [patch 7/9] imx51: fix gpio_4_24 and gpio_4_25 pad configuration Arnaud Patard (Rtp)
2010-10-19 20:43 ` [patch 8/9] efikamx: add spi nor support Arnaud Patard (Rtp)
2010-10-20 11:26 ` Amit Kucheria
2010-10-20 12:01 ` Arnaud Patard (Rtp)
2010-10-20 12:32 ` Amit Kucheria
2010-10-20 17:36 ` Matt Sealey
2010-10-20 17:55 ` Arnaud Patard (Rtp) [this message]
2010-10-20 20:51 ` Matt Sealey
2010-10-19 20:43 ` [patch 9/9] efikamx: add reset Arnaud Patard (Rtp)
2010-10-19 23:51 ` Fabio Estevam
2010-10-20 8:13 ` Arnaud Patard (Rtp)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hhciw9g.fsf@lechat.rtp-net.org \
--to=arnaud.patard@rtp-net$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox