From: arno@natisbad•org (Arnaud Ebalard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv1 3/3] arm: mvebu: add .dts file for Synology DS414
Date: Sun, 16 Nov 2014 14:17:07 +0100 [thread overview]
Message-ID: <878ujbb7zg.fsf@natisbad.org> (raw)
In-Reply-To: <20141116021521.GD15870@lunn.ch> (Andrew Lunn's message of "Sun, 16 Nov 2014 03:15:21 +0100")
Hi,
Andrew Lunn <andrew@lunn•ch> writes:
>> + internal-regs {
>> +
>> + pinctrl {
>> + pmx_ge0: pmx-ge0 {
>> + marvell,pins = "mpp0", "mpp1", "mpp2", "mpp3",
>> + "mpp4", "mpp5", "mpp6", "mpp7",
>> + "mpp8", "mpp9", "mpp10", "mpp11";
>> + marvell,function = "ge0";
>> + };
>> +
>> + pmx_ge1: pmx-ge1 {
>> + marvell,pins = "mpp12", "mpp13", "mpp14", "mpp15",
>> + "mpp16", "mpp17", "mpp18", "mpp19",
>> + "mpp20", "mpp21", "mpp22", "mpp23";
>> + marvell,function = "ge1";
>> + };
>> +
>> + pmx_spi: pmx-spi {
>> + marvell,pins = "mpp36", "mpp37",
>> + "mpp38", "mpp39";
>> + marvell,function = "spi";
>> + };
>
> It would be good to move these to armada-xp-mv78230.dtsi. I would
> suggest following the naming convention used by the 370.
Will do.
>> + spi0: spi at 10600 {
>> + status = "okay";
>> + pinctrl-0 = <&pmx_spi>;
>> + pinctrl-names = "default";
>> +
>> + spi-flash at 0 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "micron,n25q064";
>> + reg = <0>; /* Chip select 0 */
>> + spi-max-frequency = <20000000>;
>> +
>> + /*
>> + * Warning!
>> + *
>> + * Synology u-boot uses its compiled-in environment
>> + * and it seems Synology did not care to change u-boot
>> + * default configuration in order to allow saving a
>> + * modified environment at a sensible location. So,
>> + * if you do a 'saveenv' under u-boot, your modified
>> + * environment be saved will at 1MB after the start
>> + * of the flash, i.e. in the middle of the uImage.
>> + * For that reason, it is strongly advised not to
>> + * change default environment, unless you know what
>> + * you are doing.
>> + */
>
> Seems to be a cut/paste of the 370 text. So same comments.
Will correct typos.
>> + i2c at 11000 {
>> + clock-frequency = <400000>;
>> + status = "okay";
>> +
>> + s35390a: s35390a at 30 {
>> + compatible = "ssi,s35390a";
>
> sii
>
> Ah! It is also wrong in kirkwood-synology.dtsi
Good catch anyway ;-)
Cheers,
a+
next prev parent reply other threads:[~2014-11-16 13:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 0:04 [PATCHv1 0/3] arm: mvebu: add Synology DS213j and DS414 .dts files Arnaud Ebalard
2014-11-16 0:04 ` [PATCHv1 1/3] arm: mvebu: add uartX labels for Armada SoC serial nodes Arnaud Ebalard
2014-11-16 1:09 ` Andrew Lunn
2014-11-16 12:34 ` Arnaud Ebalard
2014-11-16 0:04 ` [PATCHv1 2/3] arm: mvebu: add .dts file for Synology DS213j Arnaud Ebalard
2014-11-16 2:00 ` Andrew Lunn
2014-11-16 2:31 ` Andrew Lunn
2014-11-16 13:14 ` Arnaud Ebalard
2014-11-16 23:23 ` Ben Peddell
2014-11-17 8:25 ` Arnaud Ebalard
2014-11-17 22:41 ` Ben Peddell
2014-11-17 23:23 ` Arnaud Ebalard
2014-11-16 0:04 ` [PATCHv1 3/3] arm: mvebu: add .dts file for Synology DS414 Arnaud Ebalard
2014-11-16 2:15 ` Andrew Lunn
2014-11-16 13:17 ` Arnaud Ebalard [this message]
2014-11-16 2:20 ` [PATCHv1 0/3] arm: mvebu: add Synology DS213j and DS414 .dts files Andrew Lunn
2014-11-16 13:24 ` Arnaud Ebalard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ujbb7zg.fsf@natisbad.org \
--to=arno@natisbad$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox