public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: arno@natisbad•org (Arnaud Ebalard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] ARM: mvebu: NETGEAR ReadyNAS 104 .dts file cleanup
Date: Fri, 22 Nov 2013 23:22:33 +0100	[thread overview]
Message-ID: <878uwg5b6e.fsf@natisbad.org> (raw)
In-Reply-To: <20131122213610.GC30358@obsidianresearch.com> (Jason Gunthorpe's message of "Fri, 22 Nov 2013 14:36:10 -0700")

Hi,

Jason Gunthorpe <jgunthorpe@obsidianresearch•com> writes:

> On Fri, Nov 22, 2013 at 09:07:01PM +0100, Arnaud Ebalard wrote:
>>  			mdio {
>>  				phy0: ethernet-phy at 0 {
>> +					compatible = "marvell,88e1318s";
>>  					reg = <0>;
>>  				};
>>  
>>  				phy1: ethernet-phy at 1 {
>> +					compatible = "marvell,88e1318s";
>>  					reg = <1>;
>>  				};
>>  			};
>
> Just an inquiry, are these compatible strings OK?
>
> Documentation/devicetree/bindings/net/phy.txt doesn't really give
> guidance.
>
> For self-discoverable busses I would expect to see a structured
> compatible string, or property, that encodes the phy-id - such as what
> the PCI binding does with vid/did:
>
> "compatible" Construct a list of names in most-specific to
>              least-specific order. The names shall be derived from
> 	     values of the Vendor ID, Device ID, Subsystem Vendor ID,
> 	     Subsystem ID, Revision ID and Class Code bytes, and shall
>              have the following form, and be placed in the list in the
>              following order:
>
>   pciVVVV,DDDD.SSSS.ssss.RR (1)
>
> So, I would think something like this:
>
> compatible = "ethernet-phy-id0141,0e90"; /* Marvell 88E1318 */

The compatible string I put is based on this discussion:

 http://www.spinics.net/lists/devicetree/msg11465.html

Now, considering the following:

arno at small:linux$ grep -R -88e1318s . | wc -l
0

and also the fact that *in my case* the kernel does its job
auto-detecting the PHY, I now also wonder how the kernel can
use that info and what I get by adding the compatible string.

Anyway, I'll wait for directions on how this should be fixed
before sending a v2 of the set.

Thanks for catching this, Jason.

Cheers,

a+

next prev parent reply	other threads:[~2013-11-22 22:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22 20:04 [PATCH 0/4] ARM: mvebu/kirkwood: NETGEAR ReadyNAS .dts files cleanup Arnaud Ebalard
2013-11-22 20:05 ` [PATCH 1/4] kirkwood: NETGEAR ReadyNAS Duo v2 .dts file cleanup Arnaud Ebalard
2013-11-22 20:06 ` [PATCH 2/4] ARM: mvebu: NETGEAR ReadyNAS 102 " Arnaud Ebalard
2013-11-22 20:07 ` [PATCH 3/4] ARM: mvebu: NETGEAR ReadyNAS 104 " Arnaud Ebalard
2013-11-22 21:36   ` Jason Gunthorpe
2013-11-22 22:22     ` Arnaud Ebalard [this message]
2013-11-25 19:41       ` Jason Gunthorpe
2013-11-25 22:03         ` Arnaud Ebalard
2013-11-25 22:08           ` Jason Gunthorpe
2013-12-04  3:31     ` Rob Herring
2013-11-22 20:07 ` [PATCH 4/4] ARM: NETGEAR ReadyNAS Duo v2 and RN102 .dts file whitespace cleanup Arnaud Ebalard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878uwg5b6e.fsf@natisbad.org \
    --to=arno@natisbad$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox