From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv12 0/9] OMAP3+: PRCM chain handler
Date: Tue, 10 Jan 2012 07:13:33 -0800 [thread overview]
Message-ID: <878vlfvbdu.fsf@ti.com> (raw)
In-Reply-To: <B5906170F1614E41A8A28DE3B8D1214304EDAC@DBDE01.ent.ti.com> (Vaibhav Bedia's message of "Tue, 10 Jan 2012 11:41:08 +0000")
"Bedia, Vaibhav" <vaibhav.bedia@ti•com> writes:
> Hi Kevin,
>
> On Tue, Jan 10, 2012 at 06:49:52, Hilman, Kevin wrote:
> [...]
>> >
>> > 1. IO and wakeup events are not supported on AM33XX. Since cpu_is_34xx()
>> > holds true for AM33XX I ended up adding a !cpu_is_am33xx() check in
>> > omap3xxx_prcm_init() to bypass the chain handler registration.
>>
>> > Without such a check we were seeing a crash in USB since USB_CLKCTRL on
>> > AM33XX just happens to be at the IRQENABLE_MPU_OFFSET of OMAP3.
>> > Hope such cpu_is_*() checks are acceptable.
>>
>> We try to avoid them, especially when we already have existing feature
>> flag for IO wakeups.
>>
>> Does something like (completely untested) patch below work for you?
>>
>> Of course, that implies that that feature flag is initialized correctly
>> for AM33xx.
>>
>> Kevin
>>
>>
>>
>> diff --git a/arch/arm/mach-omap2/prm2xxx_3xxx.c b/arch/arm/mach-omap2/prm2xxx_3xxx.c
>> index c1c4d86..87451d9 100644
>> --- a/arch/arm/mach-omap2/prm2xxx_3xxx.c
>> +++ b/arch/arm/mach-omap2/prm2xxx_3xxx.c
>> @@ -302,7 +302,7 @@ void omap3xxx_prm_restore_irqen(u32 *saved_mask)
>>
>> static int __init omap3xxx_prcm_init(void)
>> {
>> - if (cpu_is_omap34xx())
>> + if (cpu_is_omap34xx() && omap3_has_io_wakeup())
>> return omap_prcm_register_chain_handler(&omap3_prcm_irq_setup);
>> return 0;
>> }
>>
>
> I'll try this out once we have feature flag initialized on AM33xx.
> Can the cpu_is_omap34xx() check be completely dropped in that case?
> Or is there some other reason for retaining it?
The reason it is there is because that function is called from an
initcall. By default, the kernel builds in support for OMAP2/3/4, so
that initcall will get called on every SoC. Since it should only happen
for OMAP3, the cpu_is_ check is used.
Kevin
next prev parent reply other threads:[~2012-01-10 15:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 21:36 [PATCHv12 0/9] OMAP3+: PRCM chain handler Paul Walmsley
2011-12-15 21:36 ` [PATCH 1/9] ARM: OMAP2+: mux: add wakeup-capable hwmod mux entries to dynamic list Paul Walmsley
2011-12-15 21:41 ` Tony Lindgren
2011-12-15 21:36 ` [PATCH 2/9] ARM: OMAP2+: hwmod: Add API to enable IO ring wakeup Paul Walmsley
2011-12-15 21:36 ` [PATCH 3/9] ARM: OMAP3/4: PRM: add functions to read pending IRQs, PRM barrier Paul Walmsley
2011-12-15 21:36 ` [PATCH 4/9] ARM: OMAP: PRCM: add support for chain interrupt handler Paul Walmsley
2011-12-15 21:36 ` [PATCH 5/9] ARM: OMAP: PRCM: add suspend prepare / finish support Paul Walmsley
2011-12-15 21:36 ` [PATCH 6/9] ARM: OMAP2+: mux: add support for PAD wakeup interrupts Paul Walmsley
2011-12-15 21:36 ` [PATCH 7/9] ARM: OMAP: hwmod: add support for selecting mpu_irq for each wakeup pad Paul Walmsley
2011-12-15 21:36 ` [PATCH 8/9] ARM: OMAP3: pm: use prcm chain handler Paul Walmsley
2011-12-15 21:36 ` [PATCH 9/9] ARM: OMAP4: PRM: use PRCM interrupt handler Paul Walmsley
2011-12-16 5:10 ` [PATCHv12 0/9] OMAP3+: PRCM chain handler Paul Walmsley
2011-12-16 12:57 ` Tero Kristo
2012-01-09 5:31 ` Bedia, Vaibhav
2012-01-10 1:19 ` Kevin Hilman
2012-01-10 11:41 ` Bedia, Vaibhav
2012-01-10 15:13 ` Kevin Hilman [this message]
2012-01-11 13:49 ` Bedia, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vlfvbdu.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox