From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 6/6] ARM: OMAP: fix cpufreq build
Date: Thu, 15 Mar 2012 10:10:19 -0700 [thread overview]
Message-ID: <87aa3hdc3o.fsf@ti.com> (raw)
In-Reply-To: <E1S87xU-0000N8-6u@rmk-PC.arm.linux.org.uk> (Russell King's message of "Thu, 15 Mar 2012 10:31:00 +0000")
Russell King <rmk+kernel@arm•linux.org.uk> writes:
> OMAPs cpufreq requires the frequency table support, but nothing ensures
> that this is selected. This can result in configurations which fail to
> build:
>
> drivers/built-in.o:(.data+0x5238): undefined reference to `cpufreq_freq_attr_scaling_available_freqs'
> drivers/cpufreq/omap-cpufreq.c:88: undefined reference to `cpufreq_frequency_table_target'
> drivers/cpufreq/omap-cpufreq.c:60: undefined reference to `cpufreq_frequency_table_verify'
> drivers/cpufreq/omap-cpufreq.c:186: undefined reference to `cpufreq_frequency_table_cpuinfo'
> drivers/cpufreq/omap-cpufreq.c:190: undefined reference to `cpufreq_frequency_table_get_attr'
>
> Fix this by introducing a new configuration variable and having that
> select CPU_FREQ_TABLE.
>
> Signed-off-by: Russell King <rmk+kernel@arm•linux.org.uk>
> ---
> arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 2 +-
> arch/arm/mach-omap2/clock.c | 2 +-
> arch/arm/mach-omap2/clock.h | 2 +-
> arch/arm/plat-omap/clock.c | 2 +-
> arch/arm/plat-omap/include/plat/clock.h | 4 ++--
The arch/arm/* stuff is all code that has been removed, but the pull
request didn't make it in time for v3.4:
http://www.spinics.net/lists/arm-kernel/msg164545.html
Initially, this was intended as a cleanup because it was just dead code
removal, but since we missed v3.4, maybe we should pull out
"ARM: OMAP: clock: cleanup CPUfreq leftovers" and submit for 3.4-rc.
> drivers/cpufreq/Kconfig.arm | 5 +++++
> drivers/cpufreq/Makefile | 2 +-
This change was included in my CPUfreq pull request to Dave Jones. He
has pulled it into his fixes branch[1], but I don't see it upstream.
I've just sent a mail to Dave asking about it.
Kevin
[1] git://git.kernel.org/pub/scm/linux/kernel/git/davej/cpufreq.git fixes
next prev parent reply other threads:[~2012-03-15 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 10:28 Lost fixes? Russell King - ARM Linux
2012-03-15 10:30 ` [PATCH 4/6] ARM: OMAP: fix missing __devexit_p() annotations Russell King
2012-03-15 11:06 ` Jean Pihet
2012-03-15 16:59 ` Tony Lindgren
2012-03-15 10:30 ` [PATCH 5/6] ARM: OMAP2+: I2C: always compile I2C reset code, even if I2C driver is not built Paul Walmsley
2012-03-15 16:56 ` Tony Lindgren
2012-03-15 10:31 ` [PATCH 6/6] ARM: OMAP: fix cpufreq build Russell King
2012-03-15 17:10 ` Kevin Hilman [this message]
2012-03-15 18:47 ` Paul Walmsley
2012-03-26 8:32 ` Russell King - ARM Linux
2012-03-26 22:07 ` Kevin Hilman
2012-03-15 10:44 ` Lost fixes? Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa3hdc3o.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox