From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/6] OMAP3: cpuidle: next C-state decision depends on the PM QoS MPU and CORE constraints
Date: Tue, 13 Dec 2011 15:49:00 -0800 [thread overview]
Message-ID: <87aa6wt4lv.fsf@ti.com> (raw)
In-Reply-To: <1323706701-6627-5-git-send-email-j-pihet@ti.com> (jean pihet's message of "Mon, 12 Dec 2011 17:18:19 +0100")
jean.pihet at newoldbits.com writes:
> From: Jean Pihet <j-pihet@ti•com>
>
> The MPU latency figures for cpuidle include the MPU itself and also
> the peripherals needed for the MPU to execute instructions (e.g.
> main memory, caches, IRQ controller, MMU etc). On OMAP3 those
> peripherals belong to the MPU and CORE power domains and so the
> cpuidle C-states are a combination of MPU and CORE states.
>
> This patch implements the relation between the cpuidle and per-
> device PM QoS frameworks in the OMAP3 specific idle callbacks.
>
> The chosen C-state shall satisfy the following conditions:
> . the 'valid' field is enabled,
> . it satisfies the enable_off_mode flag,
> . the next state for MPU and CORE power domains is not lower than the
> next state calculated by the per-device PM QoS.
>
> Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency constraints
> on MPU, CORE and PER.
>
> Signed-off-by: Jean Pihet <j-pihet@ti•com>
nit: this patch mixes functional changes and non-functional changes
(whitespace cleanups, alignments etc.) For ease of review, it's best to
do non-functional cleanups as a separate patch.
Kevin
next prev parent reply other threads:[~2011-12-13 23:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 16:18 [PATCH v5 0/6] PM QoS: implement the OMAP low level constraints management code jean.pihet at newoldbits.com
2011-12-12 16:18 ` [PATCH 1/6] OMAP2+: powerdomain: control power domains next state jean.pihet at newoldbits.com
2011-12-12 16:18 ` [PATCH 2/6] OMAP2+: omap_hwmod: manage the wake-up latency constraints jean.pihet at newoldbits.com
2011-12-13 23:46 ` Kevin Hilman
2011-12-12 16:18 ` [PATCH 3/6] OMAP: PM: register to the per-device PM QoS framework jean.pihet at newoldbits.com
2011-12-12 16:18 ` [PATCH 4/6] OMAP3: cpuidle: next C-state decision depends on the PM QoS MPU and CORE constraints jean.pihet at newoldbits.com
2011-12-13 23:49 ` Kevin Hilman [this message]
2011-12-12 16:18 ` [PATCH 5/6] OMAP3: update cpuidle latency and threshold figures jean.pihet at newoldbits.com
2011-12-12 16:18 ` [PATCH 6/6] OMAP3: powerdomain data: add wake-up latency figures jean.pihet at newoldbits.com
2011-12-13 23:53 ` [PATCH v5 0/6] PM QoS: implement the OMAP low level constraints management code Kevin Hilman
2011-12-14 14:55 ` Jean Pihet
-- strict thread matches above, loose matches on Subject: below --
2011-12-14 14:51 [PATCH v6 " jean.pihet at newoldbits.com
2011-12-14 14:51 ` [PATCH 4/6] OMAP3: cpuidle: next C-state decision depends on the PM QoS MPU and CORE constraints jean.pihet at newoldbits.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa6wt4lv.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox