From: vzapolskiy@gmail•com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] watchdog: Add support for the Freescale MXC watchdog
Date: Sat, 20 Mar 2010 21:40:07 +0300 [thread overview]
Message-ID: <87aau2x2ew.fsf@vovsem.com> (raw)
In-Reply-To: <20100320120939.GA5515@pengutronix.de> (Wolfram Sang's message of "Sat, 20 Mar 2010 13:09:39 +0100")
Wolfram Sang <w.sang@pengutronix•de> writes:
> On Fri, Mar 19, 2010 at 06:13:27PM +0300, Vladimir Zapolskiy wrote:
>> Add driver for the Freescale MXC SoCs built-in watchdog.
>
> Any improvements over/differences to this one?
>
> http://article.gmane.org/gmane.linux.ports.arm.kernel/70753
>
> (Read the thread for the comments I received)
>
> Coincidence, I wanted to pick up my version and finish it next week. We have to
> agree how to continue. I like mine a tad better (there are some mixups of
> MX1/2+ capabilities in yours, e.g. SETTIMEOUT) and it also got review already,
> but of course I am biased ;) What do you suggest?
>
> Regards,
>
> Wolfram
Hi Wolfram,
that's a surprise for me, haven't noticed your version of the driver in
the maillist, and wrote one more watchdog driver :)
The driver is extremely simple, so from my biased position only minor
benefits can be found in my version:
* introduced spinlock to protect concurrent write to registers
* SETTIMEOUT option is present and it works well on imx31
* correct zero byte write()
* clock enabled only when watchdog node is opened
* dynamic wdt structure, which potentially simplifies future support of
several watchdogs found on imx51 and imx37 IIRC
* no critical message on close with unset NOWAYOUT on non-imx1 SoCs
Your pretty good version supports imx1, and I cann't test my version on
imx1, because I don't have such hardware on hand.
Obviously better to update your reviewed one, and I hope some comments or even
updates from my side could be accepted by you :)
With best wishes,
Vladimir
next prev parent reply other threads:[~2010-03-20 18:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 15:13 [PATCH 1/3] watchdog: Add support for the Freescale MXC watchdog Vladimir Zapolskiy
2010-03-19 15:16 ` [PATCH 2/3] imx3: Add watchdog platform device support Vladimir Zapolskiy
2010-03-22 8:42 ` Sascha Hauer
2010-03-19 15:16 ` [PATCH 3/3] imx31: add watchdog device on litekit board Vladimir Zapolskiy
2010-03-22 8:43 ` Sascha Hauer
2010-03-20 12:09 ` [PATCH 1/3] watchdog: Add support for the Freescale MXC watchdog Wolfram Sang
2010-03-20 18:40 ` Vladimir Zapolskiy [this message]
2010-03-21 10:36 ` Wolfram Sang
2010-03-21 18:27 ` Vladimir Zapolskiy
2010-03-20 14:06 ` Russell King - ARM Linux
2010-03-20 17:58 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aau2x2ew.fsf@vovsem.com \
--to=vzapolskiy@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox