Subject: Re: [PATCH v3 04/17] arm64: Add KVM_HVHE capability and has_hvhe() predicate

From: Marc Zyngier <[email-masked]>
Date: Wed, 14 Jun 2023 17:06:58 +0100

On Wed, 14 Jun 2023 08:35:13 +0100,
Shaoqin Huang <[email-masked]> wrote:
> 
> Hi Marc,
> 
> Should we have a document about the hVHE? Because it's a sw feature,
> there is no spec about it. And later people may need to read the code
> itself to understand what is hVHE.

I'm planning to eventually do that once the hVHE code actually does
something useful. So far, it doesn't really do much.

But what I really want is to *hide* this low level option, and have it
driven by something like "kvm-arm.mode=hvhe,protected". It is just
that writing a parser is hard at the point where this is evaluated (we
don't have much of the kernel running).

> 
> On 6/10/23 00:21, Marc Zyngier wrote:
> > Expose a capability keying the hVHE feature as well as a new
> > predicate testing it. Nothing is so far using it, and nothing
> > is enabling it yet.
> > 
> > Signed-off-by: Marc Zyngier <[email-masked]>
> Besides that, the code itself LGTM.
> 
> Reviewed-by: Shaoqin Huang <[email-masked]>

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel