From: felipe.balbi@linux•intel.com (Felipe Balbi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] usb: renesas_usbhs: make usbhs_write32() static
Date: Wed, 22 Jun 2016 11:15:44 +0300 [thread overview]
Message-ID: <87d1n9ljv3.fsf@linux.intel.com> (raw)
In-Reply-To: <CA+7wUsxSypNQTCQ-p0VkD=dciPFDGKCX6WGqhFjQ_CEbcTZ0fg@mail.gmail.com>
Hi,
Mathieu Malaterre <mathieu.malaterre@gmail•com> writes:
> On Tue, Jun 21, 2016 at 7:52 PM, Ben Dooks <ben.dooks@codethink•co.uk> wrote:
>> The usbhs_write32 function is not used outside of the rcar3.c
>> file, so fix the following sparse warning by making it static:
>>
>> drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was not declared. Should it be static?
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink•co.uk>
>> ---
>> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
>> Cc: linux-usb at vger.kernel.org
>> Cc: linux-renesas-soc at vger.kernel.org
>> Cc: linux-arm-kernel at lists.infradead.org
>> ---
>> drivers/usb/renesas_usbhs/rcar3.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c
>> index 38b01f2..1d70add 100644
>> --- a/drivers/usb/renesas_usbhs/rcar3.c
>> +++ b/drivers/usb/renesas_usbhs/rcar3.c
>> @@ -23,7 +23,7 @@
>> #define UGCTRL2_RESERVED_3 0x00000001 /* bit[3:0] should be B'0001 */
>> #define UGCTRL2_USB0SEL_OTG 0x00000030
>>
>> -void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data)
>> +static void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data)
>> {
>> iowrite32(data, priv->base + reg);
>> }
>> --
>> 2.8.1
>
> static inline ?
why? compiler can make that choice
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160622/f3a7f447/attachment.sig>
next prev parent reply other threads:[~2016-06-22 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 17:52 [PATCH] usb: renesas_usbhs: make usbhs_write32() static Ben Dooks
2016-06-22 7:55 ` Mathieu Malaterre
2016-06-22 8:15 ` Felipe Balbi [this message]
2016-06-24 6:36 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1n9ljv3.fsf@linux.intel.com \
--to=felipe.balbi@linux$(echo .)intel.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox