From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 net 3/6] net: mvneta: Remove unused code
Date: Mon, 01 Feb 2016 14:37:03 +0100 [thread overview]
Message-ID: <87d1sg7ds0.fsf@free-electrons.com> (raw)
In-Reply-To: <56AF5E55.9030603@cogentembedded.com> (Sergei Shtylyov's message of "Mon, 1 Feb 2016 16:32:05 +0300")
Hi Sergei,
On lun., f?vr. 01 2016, Sergei Shtylyov <sergei.shtylyov@cogentembedded•com> wrote:
> Hello.
>
> On 2/1/2016 4:07 PM, Gregory CLEMENT wrote:
>
>> Since the commit 2dcf75e2793c ("net: mvneta: Associate RX queues with
>> each CPU") all the percpu irq are used and unmask at initialization, so
>
> Unmasked, you mean?
yes and disabled would be more appropriate actually.
>
>> there is no point to unmask them first.
>
> Mask, maybe (looking at the patch)?
not mask, but here again disable would be more appropriate. The code
removed disables the interrupt.
Thanks,
Gregory
>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
>> ---
>> drivers/net/ethernet/marvell/mvneta.c | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
>> index 3d6e3137f305..861b7e0d7d5f 100644
>> --- a/drivers/net/ethernet/marvell/mvneta.c
>> +++ b/drivers/net/ethernet/marvell/mvneta.c
>> @@ -3009,14 +3009,6 @@ static int mvneta_open(struct net_device *dev)
>> goto err_cleanup_txqs;
>> }
>>
>> - /* Even though the documentation says that request_percpu_irq
>> - * doesn't enable the interrupts automatically, it actually
>> - * does so on the local CPU.
>> - *
>> - * Make sure it's disabled.
>> - */
>> - mvneta_percpu_disable(pp);
>> -
>> /* Enable per-CPU interrupt on all the CPU to handle our RX
>> * queue interrupts
>> */
>
> MBR, Sergei
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2016-02-01 13:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 13:07 [PATCH v2 net 0/6] mvneta fixes for SMP Gregory CLEMENT
2016-02-01 13:07 ` [PATCH v2 net 1/6] net: mvneta: Fix for_each_present_cpu usage Gregory CLEMENT
2016-02-01 13:07 ` [PATCH v2 net 2/6] net: mvneta: Use on_each_cpu when possible Gregory CLEMENT
2016-02-01 13:07 ` [PATCH v2 net 3/6] net: mvneta: Remove unused code Gregory CLEMENT
2016-02-01 13:32 ` Sergei Shtylyov
2016-02-01 13:37 ` Gregory CLEMENT [this message]
2016-02-01 13:07 ` [PATCH v2 net 4/6] net: mvneta: Modify the queue related fields from each cpu Gregory CLEMENT
2016-02-01 13:07 ` [PATCH v2 net 5/6] net: mvneta: The mvneta_percpu_elect function should be atomic Gregory CLEMENT
2016-02-01 13:33 ` Sergei Shtylyov
2016-02-01 13:07 ` [PATCH v2 net 6/6] net: mvneta: Fix race condition during stopping Gregory CLEMENT
2016-02-03 8:01 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1sg7ds0.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox