From: khilman@linaro•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v9 3/7] ARM: dts: enable hi4511 with device tree
Date: Fri, 30 Aug 2013 07:44:29 -0700 [thread overview]
Message-ID: <87d2ovs0fm.fsf@linaro.org> (raw)
In-Reply-To: <CAD6h2NRnjme1Hdc+5oMzrR8LYb7_rk13OeVfo0qFT=_jAbMoJg@mail.gmail.com> (Haojian Zhuang's message of "Fri, 30 Aug 2013 09:19:56 +0800")
Haojian Zhuang <haojian.zhuang@linaro•org> writes:
> On 30 August 2013 02:13, Kevin Hilman <khilman@linaro•org> wrote:
>> Haojian Zhuang <haojian.zhuang@linaro•org> writes:
>>
>>> Enable Hisilicon Hi4511 development platform with device tree support.
>>>
>>> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro•org>
>>
>> This still doesn't look quite right...
>>
>>> ---
>>> arch/arm/boot/dts/Makefile | 1 +
>>> arch/arm/boot/dts/hi3620-clk.dtsi | 1058 +++++++++++++++++++++++++++++++++++++
>>> arch/arm/boot/dts/hi3620.dtsi | 513 ++++++++++++++++++
>>> arch/arm/boot/dts/hi4511.dts | 648 +++++++++++++++++++++++
>>> 4 files changed, 2220 insertions(+)
>>> create mode 100644 arch/arm/boot/dts/hi3620-clk.dtsi
>>> create mode 100644 arch/arm/boot/dts/hi3620.dtsi
>>> create mode 100644 arch/arm/boot/dts/hi4511.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index 641b3c9..6e7c1ca 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -61,6 +61,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
>>> exynos5250-snow.dtb \
>>> exynos5420-smdk5420.dtb \
>>> exynos5440-ssdk5440.dtb
>>> +dtb-$(CONFIG_ARCH_HI3xxx) += hi4511.dtb
>>> dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
>>> ecx-2000.dtb
>>> dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \
>>> diff --git a/arch/arm/boot/dts/hi3620-clk.dtsi b/arch/arm/boot/dts/hi3620-clk.dtsi
>>> new file mode 100644
>>> index 0000000..78307c6
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/hi3620-clk.dtsi
>>> @@ -0,0 +1,1058 @@
>>> +/*
>>> + * Hisilicon Ltd. Hi3620 SoC
>>> + *
>>> + * Copyright (C) 2012-2013 Hisilicon Ltd.
>>> + * Copyright (C) 2012-2013 Linaro Ltd.
>>> + *
>>> + * Author: Haojian Zhuang <haojian.zhuang@linaro•org>
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License version 2 as
>>> + * publishhed by the Free Software Foundation.
>>> + */
>>> +
>>> +/ {
>>> + clocks {
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges;
>>> +
>>> + osc32k: osc32k {
>>> + compatible = "fixed-clock";
>>> + #clock-cells = <0>;
>>> + clock-frequency = <32768>;
>>> + clock-output-names = "osc32khz";
>>> + };
>>
>> So you've now moved these all under the clocks node, but this still
>> isn't addressing Stephen's comments about using the
>> node-name at unit-address and the reg property in each node.
>>
>> [...]
>>
>>> + sysctrl: system-controller at fc802000 {
>>> + compatible = "hisilicon,sysctrl";
>>> + reg = <0xfc802000 0x1000>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>
>> Why is sysctrl and all of its children now under the clocks node?
>>
>>
>> Kevin
>
> SMP registers and clock registers are sharing the system controller.
That suggest the clock node should be a child of the sysctrl node, not
the other way around.
Kevin
next prev parent reply other threads:[~2013-08-30 14:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 13:10 [PATCH v9 0/7] enable hi3xxx SoC Haojian Zhuang
2013-08-28 13:10 ` [PATCH v9 1/7] clk: hi3xxx: add clock support Haojian Zhuang
2013-08-28 13:10 ` [PATCH v9 2/7] ARM: hi3xxx: add board support with device tree Haojian Zhuang
2013-08-28 13:10 ` [PATCH v9 3/7] ARM: dts: enable hi4511 " Haojian Zhuang
2013-08-29 18:13 ` Kevin Hilman
2013-08-30 1:19 ` Haojian Zhuang
2013-08-30 14:44 ` Kevin Hilman [this message]
2013-09-02 8:33 ` Linus Walleij
2013-08-28 13:10 ` [PATCH v9 4/7] ARM: config: enable hi3xxx in multi_v7_defconfig Haojian Zhuang
2013-08-28 13:10 ` [PATCH v9 5/7] ARM: config: add defconfig for Hi3xxx Haojian Zhuang
2013-08-28 13:10 ` [PATCH v9 6/7] ARM: hi3xxx: add smp support Haojian Zhuang
2013-08-29 18:24 ` Kevin Hilman
2013-08-28 13:10 ` [PATCH v9 7/7] ARM: hi3xxx: add hotplug support Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2ovs0fm.fsf@linaro.org \
--to=khilman@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox