From: khilman@deeprootsystems•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/6] davinci: edma: clear events in edma_start()
Date: Tue, 25 May 2010 08:31:00 -0700 [thread overview]
Message-ID: <87d3wkov63.fsf@deeprootsystems.com> (raw)
In-Reply-To: <00f701cafc0e$23dedbf0$6b9c93d0$@raj@ti.com> (Sudhakar Rajashekhara's message of "Tue\, 25 May 2010 18\:58\:19 +0530")
"Sudhakar Rajashekhara" <sudhakar.raj@ti•com> writes:
> Hi Stanley,
>
> On Tue, May 25, 2010 at 15:35:52, stanley.miao wrote:
>> Kevin Hilman wrote:
>> > <snip>
>> >>>
>> >>>
>> >> This patch causes that the sound can not work normally on OMAP_L138.
>> >>
>> >>
>> >
>> > Can you describe "can not work normally"? Does that mean simply does
>> > not work, or works with pops & clicks etc.?
>> >
>> > Just to clarify... how did you isolate it to this patch.
>> >
>> > If you revert just this patch on current davinci git, do you have
>> > working sound as you expect again?
>> >
>> Below is the test result:
>>
>> $/root> aplay audiodump.wav
>> Playing WAVE 'audiodump.wav' : Signed 16 bit Little Endian, Rate 44100
>> Hz, Stereo
>> aplay: pcm_write:1269: write error: Input/output error
>> $/root>
>>
>> After revert it, the audio works fine.
>>
>
> This patch works fine on DM644x which has McBSP but breaks audio on OMAP L138
> (as you had mentioned) which has McASP. Ideally McBSP/McASP should start after
> EDMA is started. If not then this patch clears the EDMA event which is actually
> set by McBSP/McASP. As this patch is working fine on DM644x, I think there is
> some issue in the audio driver which needs to be debugged.
In the mean time, I think it makes sense to revert $SUBJECT patch in
davinci git until the audio driver is debugged.
Kevin
next prev parent reply other threads:[~2010-05-25 15:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 15:52 [PATCH 0/6] davinci fixes for 2.6.34-rc Kevin Hilman
2010-03-17 15:52 ` [PATCH 1/6] davinci: timers: don't enable timer until clocksource is initialized Kevin Hilman
2010-03-17 15:52 ` [PATCH 2/6] davinci: da8xx/omap-l1: fix build error when CONFIG_DAVINCI_MUX is undefined Kevin Hilman
2010-03-17 15:52 ` [PATCH 3/6] davinci: edma: clear events in edma_start() Kevin Hilman
2010-05-24 11:59 ` stanley.miao
2010-05-24 17:27 ` Kevin Hilman
2010-05-25 10:05 ` stanley.miao
2010-05-25 13:28 ` Sudhakar Rajashekhara
2010-05-25 15:31 ` Kevin Hilman [this message]
2010-05-25 15:30 ` Kevin Hilman
2010-03-17 15:52 ` [PATCH 4/6] davinci: DM365: fix duplicate default IRQ priorities Kevin Hilman
2010-03-17 15:52 ` [PATCH 5/6] davinci: misc cleanups from sparse Kevin Hilman
2010-03-17 15:52 ` [PATCH 6/6] davinci: sparse: gpio: void casting Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3wkov63.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox