From: arno@natisbad•org (Arnaud Ebalard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv7 1/1] Add support for GMT G762/G763 PWM fan controllers
Date: Thu, 20 Jun 2013 21:10:22 +0200 [thread overview]
Message-ID: <87ehbwvbs1.fsf@natisbad.org> (raw)
In-Reply-To: <20130620013823.GC29521@roeck-us.net> (Guenter Roeck's message of "Wed, 19 Jun 2013 18:38:23 -0700")
Hi Guenter,
Guenter Roeck <linux@roeck-us•net> writes:
> On Wed, Jun 19, 2013 at 09:34:34PM +0200, Arnaud Ebalard wrote:
>>
>> GMT G762/763 fan speed PWM controller is connected directly to a fan
>> and performs closed-loop or open-loop control of the fan speed. Two
>> modes - PWM or DC - are supported by the chip. Introduced driver
>> provides various knobs to control the operations of the chip (via
>> sysfs interface). Specific characteristics of the system can be passed
>> either using board init code or via DT. Documentation for both the
>> driver and DT bindings are also provided.
>>
>> Signed-off-by: Arnaud Ebalard <arno@natisbad•org>
>
> Couple of additional nitpicks plus a bug.
>
>> +static void g762_of_clock_disable(struct i2c_client *client)
>> +{
>> + struct g762_data *data = i2c_get_clientdata(client);
>> +
>> + if (data->clk)
>> + return;
>
> Guess this should be
> if (!data->clk)
> return;
>
> Small but significant difference ...
I am going to find me a hole to hide in. Thanks for catching
this. Resending a v8 after fixing it and the other points you
pointed.
Cheers,
a+
prev parent reply other threads:[~2013-06-20 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 19:34 [PATCHv7 1/1] Add support for GMT G762/G763 PWM fan controllers Arnaud Ebalard
2013-06-20 1:38 ` Guenter Roeck
2013-06-20 19:10 ` Arnaud Ebalard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehbwvbs1.fsf@natisbad.org \
--to=arno@natisbad$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox