From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv4 4/8] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting
Date: Mon, 06 Aug 2012 16:32:16 -0700 [thread overview]
Message-ID: <87ehnj4mwv.fsf@ti.com> (raw)
In-Reply-To: <878ve5j8se.fsf@ti.com> (Kevin Hilman's message of "Fri, 27 Jul 2012 12:36:33 -0700")
Kevin Hilman <khilman@ti•com> writes:
> Tero Kristo <t-kristo@ti•com> writes:
>
>> mpu / core powerdomain usecounts are now statically increased
>> by 1 during MPU activity. This allows the domains to reflect
>> actual usage, and will allow the usecount to reach 0 just before
>> all CPUs are ready to idle. Proper powerdomain usecounts are
>> propageted to voltagedomain level also, and will allow vc
>> callbacks to be triggered at right point of time.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti•com>
>> Cc: Paul Walmsley <paul@pwsan•com>
>> Cc: Kevin Hilman <khilman@ti•com>
>
> IMO, the idea is fine, but I'm not crazy about the implementation in
> powerdomain.c, which is meant for pwrdm generic code. In particular,
> I'm not crazy about the pwrdm lookups in powerdomain.c.
>
> Since pm<soc>.c already has references to mpu_pwrdm and core_pwrdm, why
> not just add the pwrdm_clkdm_enable/disable calls directly in pm<soc>.c
>
> Also, the changelog should be a bit more specific about why CORE
> powerdomain is also handled here when most of the code only talks about
> the CPU.
After playing with this some more, and doing a test hack of my idea
above, along with the per-pwrdm pre/post changes now in mainline, I
thinks this series should go one step further.
Basically, we should be able to get rid of the calls to
prdm_pre|post_transition that are outside the powerdomain code. With
the addition of pwrdm_clkdm_enable|disable, it seems that the pre|post
transition calls should be called directly from
pwrdm_clkdm_enable|disable when the usecount transitions to/from zero.
Kevin
next prev parent reply other threads:[~2012-08-06 23:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 14:19 [PATCHv4 0/8] ARM: OMAP: pm: usecounting changes Tero Kristo
2012-07-13 14:19 ` [PATCHv4 1/8] ARM: OMAP: clk: add support for omap_clk_for_each Tero Kristo
2012-07-16 10:04 ` Rajendra Nayak
2012-07-16 11:42 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 2/8] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking Tero Kristo
2012-07-16 10:15 ` Rajendra Nayak
2012-07-27 19:14 ` Kevin Hilman
2012-08-06 23:31 ` Kevin Hilman
2012-09-07 9:23 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 3/8] ARM: OMAP3+: voltage: add support for voltagedomain usecounts Tero Kristo
2012-07-16 10:23 ` Rajendra Nayak
2012-07-24 20:58 ` Vishwanath Sripathy
2012-07-25 8:07 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 4/8] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting Tero Kristo
2012-07-16 10:30 ` Rajendra Nayak
2012-07-27 19:36 ` Kevin Hilman
2012-07-30 8:40 ` Tero Kristo
2012-08-06 10:14 ` Jean Pihet
2012-09-07 9:30 ` Tero Kristo
2012-09-07 21:48 ` Kevin Hilman
2012-08-06 23:32 ` Kevin Hilman [this message]
2012-07-13 14:19 ` [PATCHv4 5/8] ARM: OMAP3: set autoidle flag for sdrc_ick Tero Kristo
2012-07-16 10:39 ` Rajendra Nayak
2012-07-13 14:19 ` [PATCHv4 6/8] ARM: OMAP: pm-debug: enhanced usecount debug support Tero Kristo
2012-07-16 10:50 ` Rajendra Nayak
2012-07-16 11:45 ` Tero Kristo
2012-07-16 12:14 ` Rajendra Nayak
2012-07-27 19:55 ` Kevin Hilman
2012-07-30 8:36 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 7/8] ARM: OMAP: clockdomain: add support for preventing autodep delete Tero Kristo
2012-07-16 11:00 ` Rajendra Nayak
2012-07-17 14:56 ` Tero Kristo
2012-07-17 21:31 ` Paul Walmsley
2012-07-18 7:15 ` Rajendra Nayak
2012-07-18 8:05 ` Tero Kristo
2012-07-18 9:04 ` Rajendra Nayak
2012-07-18 9:16 ` Tero Kristo
2012-07-27 20:12 ` Kevin Hilman
2012-07-13 14:19 ` [PATCHv4 8/8] ARM: OMAP3: do not delete per_clkdm autodeps during idle Tero Kristo
2012-09-18 22:25 ` Paul Walmsley
2012-09-18 22:43 ` Paul Walmsley
2012-09-19 22:15 ` Kevin Hilman
2012-10-16 7:29 ` Paul Walmsley
2012-10-17 0:39 ` Kevin Hilman
2012-10-31 11:59 ` Tero Kristo
2012-09-19 9:06 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehnj4mwv.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox