From: cjb@laptop•org (Chris Ball)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/9] ARM: mmp: support DT in irq
Date: Wed, 30 May 2012 15:38:51 -0400 [thread overview]
Message-ID: <87ehq1tq5w.fsf@laptop.org> (raw)
In-Reply-To: <1335515957-1798-4-git-send-email-haojian.zhuang@gmail.com> (Haojian Zhuang's message of "Fri, 27 Apr 2012 16:39:11 +0800")
Hi Haojian,
On Fri, Apr 27 2012, Haojian Zhuang wrote:
> Append new interrupt driver that could support both pxa168 and mmp2
> silicon. And this driver supports device tree.
>
> Since CONFIG_SPARSE_IRQ is enabled in arch-mmp, irq driver should
> handle reserved NR_IRQS_LEGACY in irq domain.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@gmail•com>
This patch (now in mainline) breaks boot on XO-1.75 (MMP2, non-DT).
I hit the error path below:
> + for (i = 1; i < max_icu_nr; i++) {
> + if (irq == icu_data[i].cascade_irq) {
> + domain = icu_data[i].domain;
> + data = (struct icu_chip_data *)domain->host_data;
> + break;
> + }
> + }
> + if (i >= max_icu_nr) {
> + pr_err("Spurious irq %d in MMP INTC\n", irq);
> + return;
> + }
This error path is hit because i=8 and max_icu_nr=8, which is because
we never matched (irq == icu_data[i].cascade_irq) in the for loop above.
This test is outside of a DT path, but cascade_irq appears to only ever
be set *inside* a DT path:
> + icu_data[i].cascade_irq = irq_of_parse_and_map(node, 0);
> + if (!icu_data[i].cascade_irq) {
> + ret = -EINVAL;
> + goto err;
> + }
Did you test non-DT boot with these changes?
Thanks,
- Chris.
--
Chris Ball <cjb@laptop•org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-05-30 19:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 8:39 [PATCH 0/9] add more devicetree support in arch-mmp Haojian Zhuang
2012-04-27 8:39 ` [PATCH 1/9] ARM: mmp: fix build issue on mmp with device tree Haojian Zhuang
2012-04-27 20:15 ` Arnd Bergmann
2012-04-28 3:11 ` Haojian Zhuang
2012-04-27 8:39 ` [PATCH 2/9] ARM: mmp: distinguish mmp and mmp2 in Kconfig Haojian Zhuang
2012-04-27 20:14 ` Arnd Bergmann
2012-05-02 5:53 ` Haojian Zhuang
2012-05-02 12:58 ` Arnd Bergmann
2012-04-27 8:39 ` [PATCH 3/9] ARM: mmp: support DT in irq Haojian Zhuang
2012-04-27 19:06 ` Grant Likely
2012-05-02 5:40 ` Haojian Zhuang
2012-05-02 12:51 ` Arnd Bergmann
2012-05-04 3:41 ` Haojian Zhuang
2012-05-04 12:56 ` Arnd Bergmann
2012-05-30 19:38 ` Chris Ball [this message]
2012-05-31 3:07 ` Haojian Zhuang
2012-05-31 3:23 ` Chris Ball
2012-05-31 21:11 ` Chris Ball
2012-04-27 8:39 ` [PATCH 4/9] ARM: mmp: support DT in timer Haojian Zhuang
2012-04-27 8:39 ` [PATCH 5/9] gpio: pxa: parse gpio from DTS file Haojian Zhuang
2012-04-27 8:39 ` [PATCH 6/9] ARM: mmp: support mmp2 with device tree Haojian Zhuang
2012-04-27 8:39 ` [PATCH 7/9] ARM: mmp: support pxa910 " Haojian Zhuang
2012-04-27 8:39 ` [PATCH 8/9] ARM: dts: refresh dts file for arch mmp Haojian Zhuang
2012-04-27 8:39 ` [PATCH 9/9] Documentation: update docs for mmp dt Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehq1tq5w.fsf@laptop.org \
--to=cjb@laptop$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox