From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] mmc: sdhci-xenon: Fix clock resource by adding an optional bus clock
Date: Mon, 02 Oct 2017 16:32:23 +0200 [thread overview]
Message-ID: <87fub1mxhk.fsf@free-electrons.com> (raw)
In-Reply-To: <20170930141753.7c4e34ea@xhacker.debian> (Jisheng Zhang's message of "Sat, 30 Sep 2017 14:17:53 +0800")
Hi Jisheng,
On sam., sept. 30 2017, Jisheng Zhang <Jisheng.Zhang@synaptics•com> wrote:
> Hi Thomas,
>
> On Sat, 30 Sep 2017 08:07:10 +0200 Thomas Petazzoni wrote:
>
>> Hello,
>>
>> On Sat, 30 Sep 2017 10:41:09 +0800, Jisheng Zhang wrote:
>>
>> > > + priv->axi_clk = devm_clk_get(&pdev->dev, "axi");
>> > > + if (IS_ERR(priv->axi_clk)) {
>> > > + err = PTR_ERR(priv->axi_clk);
>> > > + if (err == -EPROBE_DEFER)
>> > > + goto err_clk;
>> > > + priv->axi_clk = NULL;
>> >
>> > IMHO, this assignment could be removed. What do you think?
>>
>> No, because if the clock is not present in the Device Tree,
>> priv->axi_clk will contain an error code encoded as a pointer, so
>> priv->axi_clk will not be NULL. Hence the rest of the code that will
>
> FWICT, the clk_disable_unprepare() could also check whether the clk
> is err, am I wrong?
You're right, I've jsut checked it.
So I will remove it to have a smaller fix.
Thanks,
Gregory
>
>> operate on this clock will believe there is a valid clock pointed by
>> priv->axi_clk. So we really want to reset it to NULL when there was an
>> error getting the clock.
>>
>> Best regards,
>>
>> Thomas
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2017-10-02 14:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 13:04 [PATCH v2] mmc: sdhci-xenon: Fix clock resource by adding an optional bus clock Gregory CLEMENT
2017-09-29 18:42 ` zhoujie wu
2017-09-30 2:32 ` Jisheng Zhang
2017-09-30 2:41 ` Jisheng Zhang
2017-09-30 6:07 ` Thomas Petazzoni
2017-09-30 6:17 ` Jisheng Zhang
2017-10-02 14:32 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fub1mxhk.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox