From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 net-next 01/10] misc: sram: add optional ioremap without write combining
Date: Mon, 14 Mar 2016 09:44:35 +0100 [thread overview]
Message-ID: <87fuvt1ma4.fsf@free-electrons.com> (raw)
In-Reply-To: <1457944745-7634-2-git-send-email-gregory.clement@free-electrons.com> (Gregory CLEMENT's message of "Mon, 14 Mar 2016 09:38:56 +0100")
Hi Arnd,
I forgot to add you in CC for this patch.
What is your opinion about it?
Gregory
On lun., mars 14 2016, Gregory CLEMENT <gregory.clement@free-electrons•com> wrote:
> From: Marcin Wojtas <mw@semihalf•com>
>
> Some SRAM users may require non-bufferable access to the memory, which is
> impossible, because devm_ioremap_wc() is used for setting sram->virt_base.
>
> This commit adds optional flag 'no-memory-wc', which allow to choose remap
> method, using DT property. Documentation is updated accordingly.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf•com>
> ---
> Documentation/devicetree/bindings/sram/sram.txt | 5 +++++
> drivers/misc/sram.c | 5 ++++-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sram/sram.txt b/Documentation/devicetree/bindings/sram/sram.txt
> index 42ee9438b771..227e3a341af1 100644
> --- a/Documentation/devicetree/bindings/sram/sram.txt
> +++ b/Documentation/devicetree/bindings/sram/sram.txt
> @@ -25,6 +25,11 @@ Required properties in the sram node:
> - ranges : standard definition, should translate from local addresses
> within the sram to bus addresses
>
> +Optional properties in the sram node:
> +
> +- no-memory-wc : the flag indicating, that SRAM memory region has not to
> + be remapped as write combining. WC is used by default.
> +
> Required properties in the area nodes:
>
> - reg : iomem address range, relative to the SRAM range
> diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c
> index 736dae715dbf..69cdabea9c03 100644
> --- a/drivers/misc/sram.c
> +++ b/drivers/misc/sram.c
> @@ -360,7 +360,10 @@ static int sram_probe(struct platform_device *pdev)
> return -EBUSY;
> }
>
> - sram->virt_base = devm_ioremap_wc(sram->dev, res->start, size);
> + if (of_property_read_bool(pdev->dev.of_node, "no-memory-wc"))
> + sram->virt_base = devm_ioremap(sram->dev, res->start, size);
> + else
> + sram->virt_base = devm_ioremap_wc(sram->dev, res->start, size);
> if (IS_ERR(sram->virt_base))
> return PTR_ERR(sram->virt_base);
>
> --
> 2.5.0
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2016-03-14 8:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 8:38 [PATCH v6 net-next 00/10] API set for HW Buffer management Gregory CLEMENT
2016-03-14 8:38 ` [PATCH v6 net-next 01/10] misc: sram: add optional ioremap without write combining Gregory CLEMENT
2016-03-14 8:44 ` Gregory CLEMENT [this message]
2016-03-14 8:38 ` [PATCH v6 net-next 02/10] ARM: dts: armada-38x: add buffer manager nodes Gregory CLEMENT
2016-03-14 8:38 ` [PATCH v6 net-next 03/10] ARM: dts: armada-38x: enable buffer manager support on Armada 38x boards Gregory CLEMENT
2016-03-14 8:38 ` [PATCH v6 net-next 04/10] ARM: dts: armada-xp: add buffer manager nodes Gregory CLEMENT
2016-03-14 8:39 ` [PATCH v6 net-next 05/10] ARM: dts: armada-xp: enable buffer manager support on Armada XP boards Gregory CLEMENT
2016-03-14 8:39 ` [PATCH v6 net-next 06/10] ARM: dts: armada-xp-openblocks-ax3-4: Add BM support Gregory CLEMENT
2016-03-14 8:39 ` [PATCH v6 net-next 07/10] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information Gregory CLEMENT
2016-03-14 8:39 ` [PATCH v6 net-next 08/10] net: mvneta: bm: add support for hardware buffer management Gregory CLEMENT
2016-03-14 9:57 ` Jesper Dangaard Brouer
2016-03-14 8:39 ` [PATCH v6 net-next 09/10] net: add a hardware buffer management helper API Gregory CLEMENT
2016-03-14 10:33 ` Jesper Dangaard Brouer
2016-03-14 8:39 ` [PATCH v6 net-next 10/10] net: mvneta: Use the new hwbm framework Gregory CLEMENT
2016-03-14 16:21 ` [PATCH v6 net-next 00/10] API set for HW Buffer management David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuvt1ma4.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox