public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: arno@natisbad•org (Arnaud Ebalard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: mvebu: Add Netgear ReadyNAS 2120 board
Date: Mon, 11 Nov 2013 01:32:43 +0100	[thread overview]
Message-ID: <87fvr393ro.fsf@natisbad.org> (raw)
In-Reply-To: <527ED9E5.80800@gmail.com> (Sebastian Hesselbarth's message of "Sun, 10 Nov 2013 01:57:09 +0100")

Hi,

I thought it would be a simple update but one of your comment gave me a
run for my money ;-)

Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com> writes:

>>>> +				status = "okay";
>>>> +			};
>>>> +
>>>> +			mdio {
>>>> +				phy0: ethernet-phy at 0 {
>>>> +					reg = <0>;
>>>
>>> Can you evaluate PHYs compatible from u-boot or post vendor:prodid
>>> from MDIO registers?
>>
>> Looking at the PCB, 88E1318-NNB2. I will dig into Documentation/ the
>> associated compatible. Out of curiosity, how do you get the PHY model
>> from u-boot or userland?
>
> If it is 88e1318 the compatible is "marvell,88e1318" then. I usually
> look at u-boot messages which sometimes reveal the PHY used. If that
> is not sufficient, you can read PHY ID 1/2 (SMI address 2 and 3)
> registers and go looking for model numbers.

For the records, another solution is to look under /sys/:

root at thin:/sys/bus/mdio_bus/drivers# find -name '*mdio*'
./Marvell 88E1318S/d0072004.mdio-mi:00
./Marvell 88E1318S/d0072004.mdio-mi:01

I guess the driver just looks at the PHY ID to detect the flavour.

Now regarding the compatible string you propose,  did some grep calls
and was unable to find a reference to marvell,88e1318 or even 88e138 and
was unable to find any. How does the kernel do something with it to
somehow inflect the selection of the right driver/flavour?

>>> Both properties above are not required, so please remove them.
>>>
>>>> +	       g762_clk: fixedclk {
>>>
>>> s/fixedclk/oscillator/ ?

In fact, if I change 'fixedclk' for 'oscillator', then I am unable to
boot: my SATA disk get unrecognized in a storm of insane
messages. Obviously, because I had modified the whole .dts to handle all
the points in your revieuw, I spent some time finding the root
cause. But that was interesting on many aspects and the continuation of
a debugging week end ;-)

Can you confirm the following: g762_clk is a *label for the node*, which
is referenced via specific properties of g762 at xx nodes, so that they get
a clock frequency (a property of g762_clk). And fixedclk is *the name of
the node*. In that specific case, fixedclk is ok because it does not
collide w/ any existing node. But 'oscillator' is already defined in
armada-xp.dtsi (included via armada-370-xp.dtsi):

	clocks {
		/* 25 MHz reference crystal */
		refclk: oscillator {
			compatible = "fixed-clock";
			#clock-cells = <0>;
			clock-frequency = <25000000>;
		};
	};

So I guess the renaming I did from 'fixedclk' to 'oscillator' just
somehow overloaded the armada-xp.dtsi 25Mhz clock for a 32KHz one, hence
the inability to boot. If I am correct, I guess it would be nice to have
some checks from dtc when compiling the .dts to verify the uniqueness of
nodes in order to avoid such things.

Comments welcome.

Cheers,

a+

next prev parent reply	other threads:[~2013-11-11  0:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-09 20:27 [PATCH] ARM: mvebu: Add Netgear ReadyNAS 2120 board Arnaud Ebalard
2013-11-09 21:08 ` Andrew Lunn
2013-11-09 21:26   ` Arnaud Ebalard
2013-11-09 23:57 ` Sebastian Hesselbarth
2013-11-10  0:42   ` Arnaud Ebalard
2013-11-10  0:57     ` Sebastian Hesselbarth
2013-11-11  0:32       ` Arnaud Ebalard [this message]
2013-11-11  1:09         ` Sebastian Hesselbarth
2013-11-10  8:15   ` Thomas Petazzoni
2013-11-11 14:47   ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvr393ro.fsf@natisbad.org \
    --to=arno@natisbad$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox