Subject: Re: [PATCH] ARM: select legacy gpiolib interfaces where used

From: Gregory CLEMENT <[email-masked]>
Date: Fri, 29 May 2026 17:04:00 +0200

Arnd Bergmann <[email-masked]> writes:

> From: Arnd Bergmann <[email-masked]>
>
> A few old machines have not been converted away from the old-style
> gpiolib interfaces. Make these select the new CONFIG_GPIOLIB_LEGACY
> symbol so the code still works where it is needed but can be left
> out otherwise.
>
> Acked-by: Krzysztof Kozlowski <[email-masked]>
> Signed-off-by: Arnd Bergmann <[email-masked]>

for mv78xx0 and orion5x

Acked-by: Gregory CLEMENT <[email-masked]>

Thanks,

Gregory
> ---
>  arch/arm/mach-mv78xx0/Kconfig     | 1 +
>  arch/arm/mach-orion5x/Kconfig     | 1 +
>  arch/arm/mach-pxa/Kconfig         | 1 +
>  arch/arm/mach-s3c/Kconfig.s3c64xx | 1 +
>  arch/arm/mach-sa1100/Kconfig      | 1 +
>  5 files changed, 5 insertions(+)
>
> diff --git a/arch/arm/mach-mv78xx0/Kconfig b/arch/arm/mach-mv78xx0/Kconfig
> index 9de3bbc09c3a..670e6587827e 100644
> --- a/arch/arm/mach-mv78xx0/Kconfig
> +++ b/arch/arm/mach-mv78xx0/Kconfig
> @@ -6,6 +6,7 @@ menuconfig ARCH_MV78XX0
>  	depends on ATAGS
>  	select CPU_FEROCEON
>  	select GPIOLIB
> +	select GPIOLIB_LEGACY
>  	select MVEBU_MBUS
>  	select FORCE_PCI
>  	select PLAT_ORION_LEGACY
> diff --git a/arch/arm/mach-orion5x/Kconfig b/arch/arm/mach-orion5x/Kconfig
> index ee449ca032d2..cef19bea6164 100644
> --- a/arch/arm/mach-orion5x/Kconfig
> +++ b/arch/arm/mach-orion5x/Kconfig
> @@ -5,6 +5,7 @@ menuconfig ARCH_ORION5X
>  	depends on CPU_LITTLE_ENDIAN
>  	select CPU_FEROCEON
>  	select GPIOLIB
> +	select GPIOLIB_LEGACY
>  	select MVEBU_MBUS
>  	select FORCE_PCI
>  	select PCI_QUIRKS
> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
> index 10e472f4fa43..66e26990e2c8 100644
> --- a/arch/arm/mach-pxa/Kconfig
> +++ b/arch/arm/mach-pxa/Kconfig
> @@ -10,6 +10,7 @@ menuconfig ARCH_PXA
>  	select CPU_XSCALE if !CPU_XSC3
>  	select GPIO_PXA
>  	select GPIOLIB
> +	select GPIOLIB_LEGACY
>  	select PLAT_PXA
>  	help
>  	  Support for Intel/Marvell's PXA2xx/PXA3xx processor line.
> diff --git a/arch/arm/mach-s3c/Kconfig.s3c64xx b/arch/arm/mach-s3c/Kconfig.s3c64xx
> index 8f40af063ad6..3f97fba8e4f5 100644
> --- a/arch/arm/mach-s3c/Kconfig.s3c64xx
> +++ b/arch/arm/mach-s3c/Kconfig.s3c64xx
> @@ -101,6 +101,7 @@ config MACH_WLF_CRAGG_6410
>  	depends on ATAGS
>  	depends on I2C=y
>  	select CPU_S3C6410
> +	select GPIOLIB_LEGACY
>  	select LEDS_GPIO_REGISTER
>  	select S3C64XX_DEV_SPI0
>  	select S3C64XX_SETUP_FB_24BPP
> diff --git a/arch/arm/mach-sa1100/Kconfig b/arch/arm/mach-sa1100/Kconfig
> index 0fb4c24cfad5..e23700e0d6c8 100644
> --- a/arch/arm/mach-sa1100/Kconfig
> +++ b/arch/arm/mach-sa1100/Kconfig
> @@ -13,6 +13,7 @@ menuconfig ARCH_SA1100
>  	select CPU_FREQ
>  	select CPU_SA1100
>  	select GPIOLIB
> +	select GPIOLIB_LEGACY
>  	select IRQ_DOMAIN
>  	select ISA
>  	select NEED_MACH_MEMORY_H
> -- 
> 2.39.5
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com