From: khilman@linaro•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v12 01/08] ARM: hi3xxx: add board support with device tree
Date: Tue, 17 Dec 2013 16:06:39 -0800 [thread overview]
Message-ID: <87haa7nhtc.fsf@linaro.org> (raw)
In-Reply-To: <1386748497-11290-2-git-send-email-haojian.zhuang@gmail.com> (Haojian Zhuang's message of "Wed, 11 Dec 2013 15:54:50 +0800")
Haojian Zhuang <haojian.zhuang@linaro•org> writes:
> From: Haojian Zhuang <haojian.zhuang@linaro•org>
>
> Add board support with device tree for Hisilicon Hi3620 SoC platform.
>
This patch still has checkpatch problems:
ERROR: Use of const init definition must use __initconst
#166: FILE: arch/arm/mach-hi3xxx/hi3xxx.c:51:
+static const char *hi3xxx_compat[] __initdata = {
I know you're frustrated that it's taken a long time to get this stuff
merged, but these are the kinds of mistakes that make us have to take a
*very* close look at every detail, which greatly slows down the process.
I'll fix this up locally, but please be sure to run checkpatch on your
patches before submitting.
> Changelog:
> v11:
> 1. Add comments for iotable.
>
> v10:
> 1. Add .map_io() & debug_ll_io_init() back. Since debug_ll_io_init() is
> only called if .map_io() isn't assigned. Use .map_io() to setup static
> IO mapping that is used in clock driver.
>
> v3:
> 1. Remove .map_io() in DT machine descriptor. Since debug_ll_io_init()
> is called by default.
> 2. Remove .init_machine() in DT machine descriptor. Since
> of_platform_populate() is called by default in DT mode.
>
> v2:
> 1. Remove .init_irq() in DT machine descriptor. Since irqchip_init()
> is called by default in DT mode.
Also not a major deal, but typically the full changelog history goes
after the '---' since in most cases, it's not relevant to the permanent
git history.
Kevin
next prev parent reply other threads:[~2013-12-18 0:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 7:54 [PATCH v12 00/08] enable hisilicon hi3xxx SoC Haojian Zhuang
2013-12-11 7:54 ` [PATCH v12 01/08] ARM: hi3xxx: add board support with device tree Haojian Zhuang
2013-12-18 0:06 ` Kevin Hilman [this message]
2013-12-11 7:54 ` [PATCH v12 02/08] ARM: dts: enable hi4511 " Haojian Zhuang
2013-12-11 7:54 ` [PATCH v12 03/08] ARM: config: enable hi3xxx in multi_v7_defconfig Haojian Zhuang
2013-12-11 7:54 ` [PATCH v12 04/08] ARM: config: add defconfig for Hi3xxx Haojian Zhuang
2013-12-11 7:54 ` [PATCH v12 05/08] ARM: hi3xxx: add smp support Haojian Zhuang
2013-12-18 0:38 ` Kevin Hilman
2013-12-11 7:54 ` [PATCH v12 06/08] ARM: hi3xxx: add hotplug support Haojian Zhuang
2013-12-18 0:40 ` Kevin Hilman
2013-12-11 7:54 ` [PATCH v12 07/08] ARM: dts: enable clock binding on Hi3620 Haojian Zhuang
2013-12-18 0:20 ` Kevin Hilman
2013-12-11 7:54 ` [PATCH v12 08/08] ARM: hi3xxx: select GPIO in Kconfig Haojian Zhuang
2013-12-18 0:44 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haa7nhtc.fsf@linaro.org \
--to=khilman@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox