From: arnaud.patard@rtp-net•org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists•infradead.org
Subject: [patch 1/1] kirkwood: set tx_csum_limit
Date: Thu, 26 Jul 2012 12:15:05 +0200 [thread overview]
Message-ID: <87hasu96c6.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <20120726094551.GA14943@lunn.ch> (Andrew Lunn's message of "Thu, 26 Jul 2012 11:45:51 +0200")
Andrew Lunn <andrew@lunn•ch> writes:
>> >> orion_ge00_init(eth_data, DOVE_GE00_PHYS_BASE,
>> >> - IRQ_DOVE_GE00_SUM, IRQ_DOVE_GE00_ERR);
>> >> + IRQ_DOVE_GE00_SUM, IRQ_DOVE_GE00_ERR, 0);
>> >> }
>> >
>> > You might want to add a constant for TX_CSUM_NO_LIMIT or something like that,
>> > rather than a plain 0 which might be a little misleading.
>> >
>>
>> It's not to set an unlimited value but to tell the driver it has to
>> use its default value. This limit is only valid for kirkwood but given
>> that orion_ge*_init functions are used on all platforms, I have to set
>
> So how about TX_CSUM_DEFAULT_LIMIT?
sounds better :)
>
> It would also be nice if you could change the change log text to
> something like:
>
> ARM: Orion: Set eth packet size csum offload limit
>
> The mv643xx ethernet controller limits the packet size for the TX
> checksum offloading. This patch sets this limits for Kirkwood and
> Dove which have smaller limits that the default.
>
ok. updated. Updated patch will follow soon
> I would like to consistently use the prefixes:
>
> ARM: Orion:
>
maybe it'll be replaced by mvebu some day ?
Arnaud
prev parent reply other threads:[~2012-07-26 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 7:12 [patch 1/1] kirkwood: set tx_csum_limit Arnaud Patard (Rtp)
2012-07-26 9:15 ` Florian Fainelli
2012-07-26 9:28 ` Arnaud Patard (Rtp)
2012-07-26 9:44 ` Florian Fainelli
2012-07-26 9:45 ` Andrew Lunn
2012-07-26 10:15 ` Arnaud Patard (Rtp) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hasu96c6.fsf@lebrac.rtp-net.org \
--to=arnaud.patard@rtp-net$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox