From: Gregory CLEMENT <gregory.clement@bootlin•com>
To: Yangtao Li <tiny.windzz@gmail•com>,
jassisinghbrar@gmail•com, nsaenzjulienne@suse•de,
f.fainelli@gmail•com, rjui@broadcom•com, sbranden@broadcom•com,
bcm-kernel-feedback-list@broadcom•com, lftan@altera•com,
matthias.bgg@gmail•com, agross@kernel•org,
bjorn.andersson@linaro•org, mcoquelin.stm32@gmail•com,
alexandre.torgue@st•com, thierry.reding@gmail•com,
jonathanh@nvidia•com, linux-kernel@vger•kernel.org,
linux-rpi-kernel@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
nios2-dev@lists•rocketboards.org,
linux-mediatek@lists•infradead.org,
linux-arm-msm@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-tegra@vger•kernel.org
Cc: Yangtao Li <tiny.windzz@gmail•com>
Subject: Re: [PATCH 13/13] mailbox: armada-37xx-rwtm: convert to devm_platform_ioremap_resource
Date: Wed, 08 Jan 2020 10:43:04 +0100 [thread overview]
Message-ID: <87imlmb7x3.fsf@FE-laptop> (raw)
In-Reply-To: <20191228183538.26189-13-tiny.windzz@gmail.com>
Hi Yangtao Li,
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail•com>
Applied on mvebu/drivers
Thanks,
Gregory
> ---
> drivers/mailbox/armada-37xx-rwtm-mailbox.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mailbox/armada-37xx-rwtm-mailbox.c b/drivers/mailbox/armada-37xx-rwtm-mailbox.c
> index 19f086716dc5..02b7b28e6969 100644
> --- a/drivers/mailbox/armada-37xx-rwtm-mailbox.c
> +++ b/drivers/mailbox/armada-37xx-rwtm-mailbox.c
> @@ -143,7 +143,6 @@ static const struct mbox_chan_ops a37xx_mbox_ops = {
> static int armada_37xx_mbox_probe(struct platform_device *pdev)
> {
> struct a37xx_mbox *mbox;
> - struct resource *regs;
> struct mbox_chan *chans;
> int ret;
>
> @@ -156,9 +155,7 @@ static int armada_37xx_mbox_probe(struct platform_device *pdev)
> if (!chans)
> return -ENOMEM;
>
> - regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> - mbox->base = devm_ioremap_resource(&pdev->dev, regs);
> + mbox->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mbox->base)) {
> dev_err(&pdev->dev, "ioremap failed\n");
> return PTR_ERR(mbox->base);
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists•infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-08 9:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 18:35 [PATCH 01/13] mailbox: altera: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-28 18:35 ` [PATCH 02/13] mailbox: xgene-slimpro: do some cleanup Yangtao Li
2019-12-28 18:35 ` [PATCH 03/13] mailbox: qcom-apcs: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-29 1:59 ` Bjorn Andersson
2019-12-28 18:35 ` [PATCH 04/13] mailbox: mediatek: cmdq: " Yangtao Li
2019-12-30 1:58 ` CK Hu
2019-12-28 18:35 ` [PATCH 05/13] mailbox: bcm2835: " Yangtao Li
2020-01-07 10:57 ` Nicolas Saenz Julienne
2019-12-28 18:35 ` [PATCH 06/13] mailbox: hi3660: " Yangtao Li
2019-12-30 1:04 ` Leo Yan
2019-12-28 18:35 ` [PATCH 07/13] mailbox: platform-mhu: " Yangtao Li
2019-12-28 18:35 ` [PATCH 08/13] mailbox: stm32-ipcc: " Yangtao Li
2019-12-28 18:35 ` [PATCH 09/13] mailbox: sti: do some cleanup Yangtao Li
2019-12-28 18:35 ` [PATCH 10/13] mailbox: tegra: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-28 18:35 ` [PATCH 11/13] mailbox: hi6220: " Yangtao Li
2019-12-28 18:35 ` [PATCH 12/13] mailbox: omap: do some cleanup Yangtao Li
2019-12-28 18:35 ` [PATCH 13/13] mailbox: armada-37xx-rwtm: convert to devm_platform_ioremap_resource Yangtao Li
2020-01-08 9:43 ` Gregory CLEMENT [this message]
2019-12-30 1:50 ` [PATCH 01/13] mailbox: altera: " Tan, Ley Foon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imlmb7x3.fsf@FE-laptop \
--to=gregory.clement@bootlin$(echo .)com \
--cc=agross@kernel$(echo .)org \
--cc=alexandre.torgue@st$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jassisinghbrar@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=lftan@altera$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=nios2-dev@lists$(echo .)rocketboards.org \
--cc=nsaenzjulienne@suse$(echo .)de \
--cc=rjui@broadcom$(echo .)com \
--cc=sbranden@broadcom$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=tiny.windzz@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox